Use StringPiece for base CommandLine::HasSwitch

base/command_line.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 
 #include <algorithm>
 #include <ostream>
 
 #include "base/basictypes.h"
@@ skipping 75 matching lines @@
                                        switch_value);
 #elif defined(OS_POSIX)
       command_line->AppendSwitchNative(switch_string, switch_value);
 #endif
     } else {
       command_line->AppendArgNative(arg);
     }
   }
 }
 
-// Lowercase switches for backwards compatiblity *on Windows*.
+// Lowercase switches for backwards compatibility *on Windows*.
 #if defined(OS_WIN)
-std::string LowerASCIIOnWindows(const std::string& string) {
-  return StringToLowerASCII(string);
+std::string LowerASCIIOnWindows(const base::StringPiece& string) {
+  return StringToLowerASCII(string.as_string());
 }
 #elif defined(OS_POSIX)
-const std::string& LowerASCIIOnWindows(const std::string& string) {
-  return string;
+std::string LowerASCIIOnWindows(const base::StringPiece& string) {
+  return string.as_string();
 }
 #endif
 
 
 #if defined(OS_WIN)
 // Quote a string as necessary for CommandLineToArgvW compatiblity *on Windows*.
 string16 QuoteForCommandLineToArgvW(const string16& arg,
                                     bool quote_placeholders) {
   // We follow the quoting rules of CommandLineToArgvW.
   // http://msdn.microsoft.com/en-us/library/17w5ykft.aspx
@@ skipping 141 matching lines @@
 }
 
 FilePath CommandLine::GetProgram() const {
   return FilePath(argv_[0]);
 }
 
 void CommandLine::SetProgram(const FilePath& program) {
   TrimWhitespace(program.value(), TRIM_ALL, &argv_[0]);
 }
 
-bool CommandLine::HasSwitch(const std::string& switch_string) const {
+bool CommandLine::HasSwitch(const base::StringPiece& switch_string) const {
   return switches_.find(LowerASCIIOnWindows(switch_string)) != switches_.end();
 }
 
 std::string CommandLine::GetSwitchValueASCII(
     const std::string& switch_string) const {
   StringType value = GetSwitchValueNative(switch_string);
   if (!IsStringASCII(value)) {
     DLOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII.";
     return std::string();
   }
@@ skipping 166 matching lines @@
 #if defined(OS_WIN)
       arg = QuoteForCommandLineToArgvW(arg, quote_placeholders);
 #endif
       params.append(arg);
     }
   }
   return params;
 }
 
 }  // namespace base