Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 104373006: Remove deprecated video decode interfaces. (Closed)

Created:
7 years ago by ilja
Modified:
7 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Remove deprecated video decode interfaces. And clarify the texture_target parameter. BUG=None. TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241070

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -83 lines) Patch
M ppapi/api/dev/ppp_video_decoder_dev.idl View 1 3 chunks +2 lines, -38 lines 0 comments Download
M ppapi/c/dev/ppp_video_decoder_dev.h View 1 4 chunks +3 lines, -37 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ilja
Yuzhu, could you take a look?
7 years ago (2013-12-13 22:28:42 UTC) #1
yzshen1
I think it should be safe because Chrome currently only asks for v0.11. If Flash ...
7 years ago (2013-12-13 22:52:07 UTC) #2
yzshen1
LGTM after the two nits are fixed.
7 years ago (2013-12-13 22:52:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/104373006/20001
7 years ago (2013-12-13 23:25:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=235912
7 years ago (2013-12-14 02:41:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/104373006/20001
7 years ago (2013-12-14 02:53:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=236052
7 years ago (2013-12-14 07:04:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/104373006/20001
7 years ago (2013-12-16 20:27:52 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-16 23:58:26 UTC) #9
Message was sent while issue was closed. 
Change committed as 241070

Powered by Google App Engine
This is Rietveld 408576698