Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1043703003: Reland^2 "Filter invalid slots out from the SlotsBuffer after marking." (Closed)

Created:
5 years, 9 months ago by Jakob Kummerow
Modified:
5 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland^2 "Filter invalid slots out from the SlotsBuffer after marking." And reland "Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer." This reverts commits de018fbda32e8ac57d8440e8fe6c3d3386bb9b11 and d23a9f7a3e509bd405e1e4b0b851e463a4a736c2. Reason for relanding: looking fine on Canary, let's get these fixes back in. BUG=chromium:454297, chromium:470801 LOG=y TBR=ishell@chromium.org Committed: https://crrev.com/c24ed0a27798f13c9efb005c7e309c2fef21656a Cr-Commit-Position: refs/heads/master@{#27507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -29 lines) Patch
M src/heap/mark-compact.h View 3 chunks +14 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 7 chunks +143 lines, -19 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +213 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043703003/1
5 years, 9 months ago (2015-03-28 17:42:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-28 18:04:09 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 18:04:28 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24ed0a27798f13c9efb005c7e309c2fef21656a
Cr-Commit-Position: refs/heads/master@{#27507}

Powered by Google App Engine
This is Rietveld 408576698