| Index: Source/core/layout/line/InlineFlowBox.h
|
| diff --git a/Source/core/layout/line/InlineFlowBox.h b/Source/core/layout/line/InlineFlowBox.h
|
| index 2e9a868f0c26b8285cbe4ce787d46a6394e30647..ba70407c7593f100d58d6a5215bd534f0f764b92 100644
|
| --- a/Source/core/layout/line/InlineFlowBox.h
|
| +++ b/Source/core/layout/line/InlineFlowBox.h
|
| @@ -23,7 +23,6 @@
|
|
|
| #include "core/layout/LayoutObjectInlines.h"
|
| #include "core/layout/OverflowModel.h"
|
| -#include "core/layout/line/FloatToLayoutUnit.h"
|
| #include "core/layout/line/InlineBox.h"
|
| #include "core/style/ShadowData.h"
|
|
|
| @@ -107,7 +106,7 @@ public:
|
| virtual void deleteLine() override final;
|
| virtual void extractLine() override final;
|
| virtual void attachLine() override final;
|
| - virtual void adjustPosition(FloatWillBeLayoutUnit dx, FloatWillBeLayoutUnit dy) override;
|
| + virtual void adjustPosition(LayoutUnit dx, LayoutUnit dy) override;
|
|
|
| virtual void extractLineBoxFromLayoutObject();
|
| virtual void attachLineBoxToLayoutObject();
|
| @@ -175,11 +174,11 @@ public:
|
| // Helper functions used during line construction and placement.
|
| void determineSpacingForFlowBoxes(bool lastLine, bool isLogicallyLastRunWrapped, LayoutObject* logicallyLastRunLayoutObject);
|
| LayoutUnit getFlowSpacingLogicalWidth();
|
| - FloatWillBeLayoutUnit placeBoxesInInlineDirection(FloatWillBeLayoutUnit logicalLeft, bool& needsWordSpacing);
|
| - FloatWillBeLayoutUnit placeBoxRangeInInlineDirection(InlineBox* firstChild, InlineBox* lastChild,
|
| - FloatWillBeLayoutUnit& logicalLeft, FloatWillBeLayoutUnit& minLogicalLeft, FloatWillBeLayoutUnit& maxLogicalRight, bool& needsWordSpacing);
|
| - void beginPlacingBoxRangesInInlineDirection(FloatWillBeLayoutUnit logicalLeft) { setLogicalLeft(logicalLeft); }
|
| - void endPlacingBoxRangesInInlineDirection(FloatWillBeLayoutUnit logicalLeft, FloatWillBeLayoutUnit logicalRight, FloatWillBeLayoutUnit minLogicalLeft, FloatWillBeLayoutUnit maxLogicalRight)
|
| + LayoutUnit placeBoxesInInlineDirection(LayoutUnit logicalLeft, bool& needsWordSpacing);
|
| + LayoutUnit placeBoxRangeInInlineDirection(InlineBox* firstChild, InlineBox* lastChild,
|
| + LayoutUnit& logicalLeft, LayoutUnit& minLogicalLeft, LayoutUnit& maxLogicalRight, bool& needsWordSpacing);
|
| + void beginPlacingBoxRangesInInlineDirection(LayoutUnit logicalLeft) { setLogicalLeft(logicalLeft); }
|
| + void endPlacingBoxRangesInInlineDirection(LayoutUnit logicalLeft, LayoutUnit logicalRight, LayoutUnit minLogicalLeft, LayoutUnit maxLogicalRight)
|
| {
|
| setLogicalWidth(logicalRight - logicalLeft);
|
| if (knownToHaveNoOverflow() && (minLogicalLeft < logicalLeft || maxLogicalRight > logicalRight))
|
| @@ -202,7 +201,7 @@ public:
|
| virtual LayoutObject::SelectionState selectionState() const override;
|
|
|
| virtual bool canAccommodateEllipsis(bool ltr, int blockEdge, int ellipsisWidth) const override final;
|
| - virtual FloatWillBeLayoutUnit placeEllipsisBox(bool ltr, FloatWillBeLayoutUnit blockLeftEdge, FloatWillBeLayoutUnit blockRightEdge, FloatWillBeLayoutUnit ellipsisWidth, FloatWillBeLayoutUnit &truncatedWidth, bool&) override;
|
| + virtual LayoutUnit placeEllipsisBox(bool ltr, LayoutUnit blockLeftEdge, LayoutUnit blockRightEdge, LayoutUnit ellipsisWidth, LayoutUnit &truncatedWidth, bool&) override;
|
|
|
| bool hasTextChildren() const { return m_hasTextChildren; }
|
| bool hasTextDescendants() const { return m_hasTextDescendants; }
|
| @@ -218,7 +217,7 @@ public:
|
| {
|
| // FIXME: the call to enclosingLayoutRect() below is temporary and should be removed once
|
| // the transition to LayoutUnit-based types is complete (crbug.com/321237)
|
| - return m_overflow ? m_overflow->layoutOverflowRect() : frameRectIncludingLineHeight(lineTop, lineBottom).enclosingLayoutRect();
|
| + return m_overflow ? m_overflow->layoutOverflowRect() : enclosingLayoutRect(frameRectIncludingLineHeight(lineTop, lineBottom));
|
| }
|
| LayoutUnit logicalTopLayoutOverflow(LayoutUnit lineTop) const
|
| {
|
| @@ -244,10 +243,10 @@ public:
|
| {
|
| // FIXME: the call to enclosingLayoutRect() below is temporary and should be removed once
|
| // the transition to LayoutUnit-based types is complete (crbug.com/321237)
|
| - return m_overflow ? m_overflow->visualOverflowRect() : frameRectIncludingLineHeight(lineTop, lineBottom).enclosingLayoutRect();
|
| + return m_overflow ? m_overflow->visualOverflowRect() : enclosingLayoutRect(frameRectIncludingLineHeight(lineTop, lineBottom));
|
| }
|
| - LayoutUnit logicalLeftVisualOverflow() const { return m_overflow ? (isHorizontal() ? m_overflow->visualOverflowRect().x() : m_overflow->visualOverflowRect().y()) : logicalLeft().toLayoutUnit(); }
|
| - LayoutUnit logicalRightVisualOverflow() const { return m_overflow ? (isHorizontal() ? m_overflow->visualOverflowRect().maxX() : m_overflow->visualOverflowRect().maxY()) : static_cast<LayoutUnit>(ceilf(logicalRight())); }
|
| + LayoutUnit logicalLeftVisualOverflow() const { return m_overflow ? (isHorizontal() ? m_overflow->visualOverflowRect().x() : m_overflow->visualOverflowRect().y()) : logicalLeft(); }
|
| + LayoutUnit logicalRightVisualOverflow() const { return m_overflow ? (isHorizontal() ? m_overflow->visualOverflowRect().maxX() : m_overflow->visualOverflowRect().maxY()) : static_cast<LayoutUnit>(logicalRight().ceil()); }
|
| LayoutUnit logicalTopVisualOverflow(LayoutUnit lineTop) const
|
| {
|
| if (m_overflow)
|
| @@ -270,16 +269,16 @@ public:
|
|
|
| void setOverflowFromLogicalRects(const LayoutRect& logicalLayoutOverflow, const LayoutRect& logicalVisualOverflow, LayoutUnit lineTop, LayoutUnit lineBottom);
|
|
|
| - FloatRectWillBeLayoutRect frameRectIncludingLineHeight(LayoutUnit lineTop, LayoutUnit lineBottom) const
|
| + LayoutRect frameRectIncludingLineHeight(LayoutUnit lineTop, LayoutUnit lineBottom) const
|
| {
|
| if (isHorizontal())
|
| - return FloatRectWillBeLayoutRect(m_topLeft.x(), lineTop.toFloat(), width(), (lineBottom - lineTop).toFloat());
|
| - return FloatRectWillBeLayoutRect(lineTop.toFloat(), m_topLeft.y(), (lineBottom - lineTop).toFloat(), height());
|
| + return LayoutRect(m_topLeft.x(), lineTop.toFloat(), width(), (lineBottom - lineTop).toFloat());
|
| + return LayoutRect(lineTop.toFloat(), m_topLeft.y(), (lineBottom - lineTop).toFloat(), height());
|
| }
|
|
|
| - FloatRectWillBeLayoutRect logicalFrameRectIncludingLineHeight(LayoutUnit lineTop, LayoutUnit lineBottom) const
|
| + LayoutRect logicalFrameRectIncludingLineHeight(LayoutUnit lineTop, LayoutUnit lineBottom) const
|
| {
|
| - return FloatRectWillBeLayoutRect(logicalLeft(), lineTop.toFloat(), logicalWidth(), (lineBottom - lineTop).toFloat());
|
| + return LayoutRect(logicalLeft(), lineTop.toFloat(), logicalWidth(), (lineBottom - lineTop).toFloat());
|
| }
|
|
|
| bool descendantsHaveSameLineHeightAndBaseline() const { return m_descendantsHaveSameLineHeightAndBaseline; }
|
| @@ -316,7 +315,7 @@ protected:
|
|
|
| // Maximum logicalTop among all children of an InlineFlowBox. Used to
|
| // calculate the offset for TextUnderlinePositionUnder.
|
| - void computeMaxLogicalTop(FloatWillBeLayoutUnit& maxLogicalTop) const;
|
| + void computeMaxLogicalTop(LayoutUnit& maxLogicalTop) const;
|
|
|
| private:
|
| unsigned m_includeLogicalLeftEdge : 1;
|
|
|