Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1043643002: Switch line layout to LayoutUnit. (Closed)

Created:
5 years, 1 month ago by szager1
Modified:
4 years, 11 months ago
Reviewers:
dsinclair, dmazzoni, eae, fs
CC:
aboxhall, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Rik, danakj, dmazzoni, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jbroman, jchaffraix+rendering, je_julie(Not used), Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix uninitialized variable error #

Patch Set 3 : rebaseline w/merge conflicts #

Patch Set 4 : Delete FloatToLayoutUnit.h #

Patch Set 5 : rebase #

Patch Set 6 : Convert some text-related variables back to float. #

Patch Set 7 : Convert LayoutText, TextWidth, and BreakingContext to LayoutUnit. #

Patch Set 8 : Tweak a few more LayoutUnit conversions. #

Patch Set 9 : Revert some LayoutUnit conversions #

Patch Set 10 : Everything below LineBox should be float. #

Patch Set 11 : Fix uninitialized variable #

Patch Set 12 : rebaseline #

Patch Set 13 : Roll back TestExpectations prior to trybot run #

Patch Set 14 : rebaseline #

Patch Set 15 : rebaseline #

Patch Set 16 : rebaseline #

Total comments: 11

Patch Set 17 : nits scratched #

Patch Set 18 : Remove debugging code #

Total comments: 3

Patch Set 19 : Fix LayoutTextCombine::transformToInlineCoordinates #

Patch Set 20 : rebase #

Patch Set 21 : TestExpectations #

Patch Set 22 : More TestExpectations tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2852 lines, -1239 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 11 chunks +2400 lines, -16 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBR.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBlock.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 26 chunks +67 lines, -67 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 12 chunks +21 lines, -25 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutRubyBase.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutRubyBase.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutRubyText.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutRubyText.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutText.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +7 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 15 chunks +45 lines, -42 lines 0 comments Download
M Source/core/layout/LayoutTextCombine.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/LayoutTextCombine.cpp View 1 2 17 18 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/AbstractInlineTextBox.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/layout/line/AbstractInlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.h View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/layout/line/FloatToLayoutUnit.h View 1 2 3 1 chunk +0 lines, -764 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 1 2 3 11 chunks +38 lines, -39 lines 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 6 chunks +14 lines, -14 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.h View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +17 lines, -18 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 14 chunks +27 lines, -27 lines 0 comments Download
M Source/core/layout/line/InlineTextBox.h View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +9 lines, -10 lines 0 comments Download
M Source/core/layout/line/InlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 13 chunks +22 lines, -22 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.h View 1 2 3 4 4 chunks +4 lines, -5 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInline.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGInlineFlowBox.h View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/layout/svg/line/SVGInlineFlowBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.h View 1 2 3 3 chunks +9 lines, -10 lines 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +17 lines, -17 lines 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/paint/EllipsisBoxPainter.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/EllipsisBoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/InlineTextBoxPainter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +9 lines, -8 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 18 chunks +38 lines, -38 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/TextPainter.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/paint/TextPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXInlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
szager1
I need to add TestExpectations before landing. I want to do that at the last ...
4 years, 11 months ago (2015-05-26 18:45:45 UTC) #2
eae
LGTM w/nits https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutObject.cpp File Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutObject.cpp#newcode109 Source/core/layout/LayoutObject.cpp:109: const LayoutUnit& caretWidth() I'm curious, why did ...
4 years, 11 months ago (2015-05-26 18:56:32 UTC) #3
dsinclair
rslgtm w/ nit. https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutBlockFlowLine.cpp File Source/core/layout/LayoutBlockFlowLine.cpp (right): https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutBlockFlowLine.cpp#newcode1960 Source/core/layout/LayoutBlockFlowLine.cpp:1960: LayoutUnit logicalLeft; // We are only ...
4 years, 11 months ago (2015-05-26 18:59:22 UTC) #4
szager1
https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutBlockFlowLine.cpp File Source/core/layout/LayoutBlockFlowLine.cpp (right): https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutBlockFlowLine.cpp#newcode1960 Source/core/layout/LayoutBlockFlowLine.cpp:1960: LayoutUnit logicalLeft; // We are only intersted in the ...
4 years, 11 months ago (2015-05-27 05:59:42 UTC) #5
fs
Some minor layout/svg nits/suggestions. https://codereview.chromium.org/1043643002/diff/340001/Source/core/layout/svg/SVGLayoutTreeAsText.cpp File Source/core/layout/svg/SVGLayoutTreeAsText.cpp (right): https://codereview.chromium.org/1043643002/diff/340001/Source/core/layout/svg/SVGLayoutTreeAsText.cpp#newcode388 Source/core/layout/svg/SVGLayoutTreeAsText.cpp:388: ts << " " << ...
4 years, 11 months ago (2015-05-27 08:44:54 UTC) #7
szager1
https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutTextCombine.cpp File Source/core/layout/LayoutTextCombine.cpp (right): https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutTextCombine.cpp#newcode85 Source/core/layout/LayoutTextCombine.cpp:85: float centerX = boxRect.x() + boxRect.width().toFloat() / 2; On ...
4 years, 11 months ago (2015-05-27 21:24:37 UTC) #8
eae
On 2015/05/27 21:24:37, szager1 wrote: > https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutTextCombine.cpp > File Source/core/layout/LayoutTextCombine.cpp (right): > > https://codereview.chromium.org/1043643002/diff/300001/Source/core/layout/LayoutTextCombine.cpp#newcode85 > ...
4 years, 11 months ago (2015-05-27 21:25:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043643002/400001
4 years, 11 months ago (2015-05-31 09:47:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/34164)
4 years, 11 months ago (2015-05-31 09:55:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043643002/400001
4 years, 11 months ago (2015-05-31 10:07:07 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64074)
4 years, 11 months ago (2015-05-31 13:12:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043643002/420001
4 years, 11 months ago (2015-05-31 15:11:06 UTC) #22
commit-bot: I haz the power
Committed patchset #22 (id:420001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196194
4 years, 11 months ago (2015-05-31 16:33:39 UTC) #23
eae
4 years, 11 months ago (2015-05-31 19:59:23 UTC) #24
Message was sent while issue was closed. 
Wohoo!

Powered by Google App Engine
This is Rietveld 408576698