Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1043603002: Revert of Add switch (for cast_shell) to defer creation of GPU process. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jbauman, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add switch (for cast_shell) to defer creation of GPU process. (patchset #8 id:140001 of https://codereview.chromium.org/1038783002/) Reason for revert: Breaking mac browser tests? http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/436 BrowserGpuChannelHostFactoryTest.AlreadyEstablished (run #1): [ RUN ] BrowserGpuChannelHostFactoryTest.AlreadyEstablished [35311:27139:0327/154011:20111614311426:ERROR:browser_gpu_channel_host_factory.cc(134)] Failed to launch GPU process. [35311:27139:0327/154011:20111614504937:ERROR:browser_gpu_channel_host_factory.cc(134)] Failed to launch GPU process. ../../content/browser/gpu/gpu_ipc_browsertests.cc:179: Failure Value of: event Actual: false Expected: true [ FAILED ] BrowserGpuChannelHostFactoryTest.AlreadyEstablished, where TypeParam = and GetParam() = (215 ms) Original issue's description: > Add switch (for cast_shell) to defer creation of GPU process. > > For context - on Chromecast, we have the following scenario: > * We support running in the background (i.e. not rendering anything) > with our service running in the browser process to listen for incoming > cast connections. > * We cannot acquire any GPU resources (e.g. a GL context or surface) > during this time as another external application needs it, and it's a > global resource. > > We have supported starting up in the foreground and switching to this > mode for a long time. > > But now, we need to support starting up in this mode. In other words, > we need to bring up the browser process and run our cast receiver > service, but we cannot run any of the GPU process's initialisation > code until an incoming cast arrives. > > BUG=internal b/19898960 > > Committed: https://crrev.com/db7efe6dfbda08faa1e55cda4441b43dac005733 > Cr-Commit-Position: refs/heads/master@{#322655} TBR=enne@chromium.org,nasko@chromium.org,piman@chromium.org,sievers@chromium.org,halliwell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=internal b/19898960 Committed: https://crrev.com/6ab2e52d484e53a5bb25731b0463bb461992069f Cr-Commit-Position: refs/heads/master@{#322668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 5 chunks +11 lines, -23 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
Created Revert of Add switch (for cast_shell) to defer creation of GPU process.
5 years, 8 months ago (2015-03-27 22:57:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043603002/1
5 years, 8 months ago (2015-03-27 22:57:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-27 22:58:05 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 22:59:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ab2e52d484e53a5bb25731b0463bb461992069f
Cr-Commit-Position: refs/heads/master@{#322668}

Powered by Google App Engine
This is Rietveld 408576698