Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1043543002: Fixed MaximizeModeWindowState::UpdateWindowPosition(...) to not animate incorrectly. (Closed)

Created:
5 years, 9 months ago by bruthig
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed MaximizeModeWindowState::UpdateWindowPosition(...) to not animate incorrectly. Screen rotation animations were slow and janky on low end hardware. This was due to animations being incorrectly initiated on the window bounds changed events. TEST=Compared animation behavior pre-change and post-change for maximizable & non-maximizable windows when entering and exiting Touchview. Tested after opening windows when Touchview was active and when it was not. BUG=471341 Committed: https://crrev.com/bbe5bb16c1c1f1adc3ea477e2929871664f7e323 Cr-Commit-Position: refs/heads/master@{#322643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bruthig
skuhne@, can you please have a look? Ideally I'd like to get this in to ...
5 years, 9 months ago (2015-03-27 20:07:40 UTC) #2
Mr4D (OOO till 08-26)
As long as we see animations when going in or out of maximize mode this ...
5 years, 9 months ago (2015-03-27 20:14:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043543002/1
5 years, 9 months ago (2015-03-27 20:17:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 21:19:19 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 21:20:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbe5bb16c1c1f1adc3ea477e2929871664f7e323
Cr-Commit-Position: refs/heads/master@{#322643}

Powered by Google App Engine
This is Rietveld 408576698