Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: runtime/observatory/test/source_location_test.dart

Issue 1043513002: Enable strict flags for all service tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/test/source_location_test.dart
diff --git a/runtime/observatory/test/source_location_test.dart b/runtime/observatory/test/source_location_test.dart
index e0cdd2113e7f4512da7cd7a4c348fb9bfe25815b..6bc638b43d08e41ca274bab6a3599dcbd669d96c 100644
--- a/runtime/observatory/test/source_location_test.dart
+++ b/runtime/observatory/test/source_location_test.dart
@@ -1,6 +1,7 @@
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked
import 'package:observatory/service_io.dart';
import 'package:observatory/debugger.dart';
@@ -11,7 +12,7 @@ import 'dart:async';
void testFunction() {
int i = 0;
while (true) {
- if (++i % 100000000 == 0) { // line 14
+ if (++i % 100000000 == 0) { // line 15
print(i);
}
}
@@ -49,7 +50,7 @@ Future<Debugger> initDebugger(Isolate isolate) {
var tests = [
-// Bring the isolate to a breakpoint at line 14.
+// Bring the isolate to a breakpoint at line 15.
(Isolate isolate) {
return isolate.rootLib.load().then((_) {
// Listen for breakpoint event.
@@ -62,7 +63,7 @@ var tests = [
// Add the breakpoint.
var script = isolate.rootLib.scripts[0];
- return isolate.addBreakpoint(script, 14).then((ServiceObject bpt) {
+ return isolate.addBreakpoint(script, 15).then((ServiceObject bpt) {
return completer.future; // Wait for breakpoint events.
});
});
@@ -73,7 +74,7 @@ var tests = [
return initDebugger(isolate).then((debugger) {
return SourceLocation.parse(debugger, '').then((SourceLocation loc) {
expect(loc.valid, isTrue);
- expect(loc.toString(), equals('source_location_test.dart:14'));
+ expect(loc.toString(), equals('source_location_test.dart:15'));
});
});
},
@@ -81,9 +82,9 @@ var tests = [
// Parse line
(Isolate isolate) {
return initDebugger(isolate).then((debugger) {
- return SourceLocation.parse(debugger, '15').then((SourceLocation loc) {
+ return SourceLocation.parse(debugger, '16').then((SourceLocation loc) {
expect(loc.valid, isTrue);
- expect(loc.toString(), equals('source_location_test.dart:15'));
+ expect(loc.toString(), equals('source_location_test.dart:16'));
});
});
},
@@ -91,9 +92,9 @@ var tests = [
// Parse line + col
(Isolate isolate) {
return initDebugger(isolate).then((debugger) {
- return SourceLocation.parse(debugger, '15:11').then((SourceLocation loc) {
+ return SourceLocation.parse(debugger, '16:11').then((SourceLocation loc) {
expect(loc.valid, isTrue);
- expect(loc.toString(), equals('source_location_test.dart:15:11'));
+ expect(loc.toString(), equals('source_location_test.dart:16:11'));
});
});
},

Powered by Google App Engine
This is Rietveld 408576698