Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1043453002: [Password Manager Automated tests] Fix enabling the password manager (Closed)

Created:
5 years, 9 months ago by vabr (Chromium)
Modified:
5 years, 9 months ago
Reviewers:
msramek, Mike West
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager Automated tests] Fix enabling the password manager This changes the code for enabling password manager in chrome://settings. Currently, it only changes the .checked property of the associated checkbox. That does not trigger the update in preferences, one has to .click() the checkbox. BUG=369521 Committed: https://crrev.com/e7da8d59282723d86026ab74ec244b599df5a12c Cr-Commit-Position: refs/heads/master@{#322597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/test/data/password_manager/automated_tests/environment.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vabr (Chromium)
Mike, could you please review this quick fix? Martin, if you see something wrong, please ...
5 years, 9 months ago (2015-03-27 16:08:44 UTC) #2
Mike West
lgtm
5 years, 9 months ago (2015-03-27 16:10:03 UTC) #3
msramek
LGTM. Unlike the others, that one checkbox has an OnClick() handler, sorry for the confusion.
5 years, 9 months ago (2015-03-27 16:14:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043453002/1
5 years, 9 months ago (2015-03-27 16:14:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 17:41:32 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 17:42:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7da8d59282723d86026ab74ec244b599df5a12c
Cr-Commit-Position: refs/heads/master@{#322597}

Powered by Google App Engine
This is Rietveld 408576698