Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1043393002: MIPS: Fix stack claim and store to slot for large sizes. (Closed)

Created:
5 years, 8 months ago by paul.l...
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix stack claim and store to slot for large sizes. Could not encode the large slot number in opcode MiscField. TEST=mozilla/js/tests/js1_5/Regress/regress-396684.js BUG= Committed: https://crrev.com/94506cc3c295dc8a47d55afa9f249b273bd5d7f1 Cr-Commit-Position: refs/heads/master@{#27574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
paul.l...
PTAL. This doesn't use any more instructions than the previous encoding, but can support the ...
5 years, 8 months ago (2015-04-01 03:08:22 UTC) #2
balazs.kilvady
lgtm.
5 years, 8 months ago (2015-04-01 17:42:30 UTC) #3
dusmil.imgtec
lgtm.
5 years, 8 months ago (2015-04-01 17:42:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043393002/1
5 years, 8 months ago (2015-04-01 17:44:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 18:18:42 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 18:18:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94506cc3c295dc8a47d55afa9f249b273bd5d7f1
Cr-Commit-Position: refs/heads/master@{#27574}

Powered by Google App Engine
This is Rietveld 408576698