Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1043363005: make ToLocalCheck crash in release mode (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr., vogelheim, Dmitry Lomov (no reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

make ToLocalCheck crash in release mode R=svenpanne@chromium.org BUG= Committed: https://crrev.com/ce7cc5119c1e031bf1eb8476fbf5e55bef738f94 Cr-Commit-Position: refs/heads/master@{#27585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M include/v8.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcarney
ptal
5 years, 8 months ago (2015-04-02 09:56:37 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-02 10:57:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043363005/1
5 years, 8 months ago (2015-04-02 10:58:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 10:59:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ce7cc5119c1e031bf1eb8476fbf5e55bef738f94 Cr-Commit-Position: refs/heads/master@{#27585}
5 years, 8 months ago (2015-04-02 11:00:00 UTC) #7
Michael Achenbach
DevTools are crashy because of this: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2435
5 years, 8 months ago (2015-04-02 13:01:50 UTC) #9
dcarney
5 years, 8 months ago (2015-04-02 13:09:06 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1057873003/ by dcarney@chromium.org.

The reason for reverting is: breaks some devtools things.

Powered by Google App Engine
This is Rietveld 408576698