chromeos/network/network_state.h - Issue 1043343002: Use networkingPrivate.startConnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state.h

Issue 1043343002: Use networkingPrivate.startConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_cellular

Patch Set: Separate out logic and use last_error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/internet_detail.js ('K') | « chromeos/network/managed_network_configuration_handler_impl.cc ('k') | chromeos/network/network_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/network_state.h

diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h

index e4d9cce2cc090a730d8431e11f259c54abfcb0c5..eeddf8c93e0ca18d2f6ef59d5625bece276937f3 100644

--- a/chromeos/network/network_state.h

+++ b/chromeos/network/network_state.h

@@ -126,6 +126,9 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {

// Set the GUID. Called exclusively by NetworkStateHandler.

void SetGuid(const std::string& guid);

+ // Retirns |error_| if valid, otherwise returns |last_error_|.

+ std::string GetErrorState() const;

// Helpers (used e.g. when a state, error, or shill dictionary is cached)

static bool StateIsConnected(const std::string& connection_state);

static bool StateIsConnecting(const std::string& connection_state);