components/device_event_log/device_event_log_impl.cc - Issue 1043343002: Use networkingPrivate.startConnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/device_event_log/device_event_log_impl.cc

Issue 1043343002: Use networkingPrivate.startConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_cellular

Patch Set: Move ErrorState logic to ShillToONCTranslator Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/onc/onc_translator_shill_to_onc.cc ('K') | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | ui/chromeos/network/network_connect.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/device_event_log/device_event_log_impl.cc

diff --git a/components/device_event_log/device_event_log_impl.cc b/components/device_event_log/device_event_log_impl.cc

index 3d7b8862b49eb2480a09f6e9bc7da77946f27a5f..49cdbd3e09acbd830806ee5c5c979def5842504c 100644

--- a/components/device_event_log/device_event_log_impl.cc

+++ b/components/device_event_log/device_event_log_impl.cc

@@ -157,7 +157,7 @@ void SendLogEntryToVLogOrErrorLog(

const bool show_time = true;

const bool show_file = true;

const bool show_type = true;

- const bool show_level = false;

+ const bool show_level = log_entry.log_level != LOG_LEVEL_ERROR;

const bool format_html = false;

std::string output = LogEntryToString(log_entry, show_time, show_file,

show_type, show_level, format_html);