chromeos/network/onc/onc_translation_tables.cc - Issue 1043343002: Use networkingPrivate.startConnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 1043343002: Use networkingPrivate.startConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_cellular

Patch Set: Move ErrorState logic to ShillToONCTranslator Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/network/network_state.cc ('k') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('j') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/onc/onc_translation_tables.cc

diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc

index 285a7e11745a0fe82bb778d4488976709e8f209c..ad7eef81217ba4a42fa0791466ad9a29b78cfd37 100644

--- a/chromeos/network/onc/onc_translation_tables.cc

+++ b/chromeos/network/onc/onc_translation_tables.cc

@@ -187,24 +187,23 @@ const FieldTranslationEntry cellular_fields[] = {

const FieldTranslationEntry network_fields[] = {

{::onc::network_config::kGUID, shill::kGuidProperty},

{::onc::network_config::kConnectable, shill::kConnectableProperty},

- {::onc::network_config::kErrorState, shill::kErrorProperty},

{::onc::network_config::kPriority, shill::kPriorityProperty},

// Shill doesn't allow setting the name for non-VPN networks.

// Name is conditionally translated, see onc_translator_*.

- // { ::onc::network_config::kName, shill::kNameProperty },

+ // {::onc::network_config::kName, shill::kNameProperty },

// Type is converted during translation, see onc_translator_*.

- // { ::onc::network_config::kType, shill::kTypeProperty },

+ // {::onc::network_config::kType, shill::kTypeProperty },

// These fields are converted during translation, see

// onc_translator_shill_to_onc.cc. They are only converted when going from

// Shill->ONC, and ignored otherwise.

- // { ::onc::network_config::kConnectionState, shill::kStateProperty },

- // { ::onc::network_config::kRestrictedConnectivity,

- // shill::kStateProperty },

- // { ::onc::network_config::kSource, shill::kProfileProperty },

- // { ::onc::network_config::kMacAddress, shill::kAddressProperty },

+ // {::onc::network_config::kConnectionState, shill::kStateProperty },

+ // {::onc::network_config::kErrorState, shill::kErrorProperty},

+ // {::onc::network_config::kRestrictedConnectivity, shill::kStateProperty },

+ // {::onc::network_config::kSource, shill::kProfileProperty },

+ // {::onc::network_config::kMacAddress, shill::kAddressProperty },

{NULL}};

const FieldTranslationEntry ipconfig_fields[] = {