Use networkingPrivate.startConnect

chromeos/network/network_util.h

Index: chromeos/network/network_util.h
diff --git a/chromeos/network/network_util.h b/chromeos/network/network_util.h
index f07fdaff6d152c33254195128839e49c4ffbcfe6..93de52ad3ef4b687885320883c5201092621db4f 100644
--- a/chromeos/network/network_util.h
+++ b/chromeos/network/network_util.h
@@ -19,6 +19,7 @@
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chromeos/chromeos_export.h"
+#include "components/onc/onc_constants.h"
 
 namespace base {
 class ListValue;
@@ -110,6 +111,11 @@ CHROMEOS_EXPORT scoped_ptr<base::ListValue> TranslateNetworkListToONC(
     int limit,
     bool debugging_properties);
 

[pneubeck (no reviews), 2015/04/13 19:16:11]

can you rename it to include 'Service'?
ShillProperties is very broad.
E.g. ShillService instead of ShillProperties.

[stevenjb, 2015/04/13 21:16:32]

Removed instead.

+CHROMEOS_EXPORT scoped_ptr<base::DictionaryValue> TranslateShillPropertiesToONC(

[pneubeck (no reviews), 2015/04/13 19:16:11]

should have a comment, e.g. "Like TranslateShillServiceToONCPart() for
onc::kNetworkWithStateSignature and additionally integrates cached error state
from the NetworkState of service_path."

as usual, I dislike the hidden dependency on NSH. Instead of a service path,
this function should take a (const NetworkState&) or const* if it's optional.

[stevenjb, 2015/04/13 21:16:32]

I added an explicit dependency on NSH in ShillToONCTranslator instead.

+    const std::string& service_path,
+    const base::DictionaryValue& shill_properties,
+    ::onc::ONCSource onc_source);
+
 // Returns the Shill type corresponding to ONC |type| or an empty string if
 // there is no match. Only valid for ethernet, wifi, wimax, cellular, and vpn.
 CHROMEOS_EXPORT std::string TranslateONCTypeToShill(const std::string& type);