Use networkingPrivate.startConnect

chrome/browser/resources/options/chromeos/internet_detail.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: onc_data.js
 
 // NOTE(stevenjb): This code is in the process of being converted to be
 // compatible with the networkingPrivate extension API:
 // * The network property dictionaries are being converted to use ONC values.
 // * chrome.send calls will be replaced with chrome.networkingPrivate calls.
@@ skipping 1145 matching lines @@
         }
       }
   };
 
   DetailsInternetPage.loginFromDetails = function() {
     var detailsPage = DetailsInternetPage.getInstance();
     if (detailsPage.type_ == 'WiFi')
       sendChromeMetricsAction('Options_NetworkConnectToWifi');
     else if (detailsPage.type_ == 'VPN')
       sendChromeMetricsAction('Options_NetworkConnectToVPN');
-    // TODO(stevenjb): chrome.networkingPrivate.startConnect
-    chrome.send('startConnect', [detailsPage.onc_.guid()]);
+
+    var onc = detailsPage.onc_;
+    var guid = onc.guid();
+
+    // Unconfigured networks, VPNs, and secure WiFi networks with ErrorState
+    // set require configuration before they can be connected to.
+    if (!onc.getActiveValue('Connectable') || (detailsPage.type_ == 'VPN') ||

[armansito, 2015/04/01 00:41:54]

Won't this lead to a call to 'configureNetwork' if getActiveValue('Connectable')
returns false, regardless of the technology type? Is this intentional?

[stevenjb, 2015/04/01 20:53:39]

In theory that should be correct; if 'Connectable' is false, for any network
type, then Shill requires additional configuration to connect. In practice we
only support configuration for WiFi/WiMAX/VPN, so I will separate out the logic
to make this more clear.

+        (detailsPage.type_ == 'WiFi' && onc.getActiveValue('ErrorState') &&
+         onc.getWiFiSecurity() != 'None')) {
+      chrome.send('configureNetwork', [guid]);
+      return;
+    }
+
+    if (detailsPage.type_ == 'Cellular') {
+      var activationState = onc.getActiveValue('Cellular.ActivationState');
+      if (activationState != 'Activated' && activationState != 'Unknown') {
+        DetailsInternetPage.activateCellular(guid);
+        return;
+      }
+    }
+    chrome.networkingPrivate.startConnect(guid);
     PageManager.closeOverlay();
   };
 
   DetailsInternetPage.disconnectNetwork = function() {
     var detailsPage = DetailsInternetPage.getInstance();
     if (detailsPage.type_ == 'WiFi')
       sendChromeMetricsAction('Options_NetworkDisconnectWifi');
     else if (detailsPage.type_ == 'VPN')
       sendChromeMetricsAction('Options_NetworkDisconnectVPN');
     chrome.networkingPrivate.startDisconnect(detailsPage.onc_.guid());
@@ skipping 587 matching lines @@
 
     // Don't show page name in address bar and in history to prevent people
     // navigate here by hand and solve issue with page session restore.
     PageManager.showPageByName('detailsInternetPage', false);
   };
 
   return {
     DetailsInternetPage: DetailsInternetPage
   };
 });