Use networkingPrivate.startConnect

chrome/test/data/extensions/api_test/networking_private/chromeos/test.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The expectations in this test for the Chrome OS implementation. See
 // networking_private_chromeos_apitest.cc for more info.
 
 var callbackPass = chrome.test.callbackPass;
 var callbackFail = chrome.test.callbackFail;
 var assertTrue = chrome.test.assertTrue;
@@ skipping 225 matching lines @@
                   GUID: 'stub_ethernet_guid',
                   Name: 'eth0',
                   Source: 'Device',
                   Type: NetworkType.ETHERNET
                 }], result);
               }));
           }));
       }));
   },
   function getVisibleNetworks() {
     chrome.networkingPrivate.getVisibleNetworks(

[pneubeck (no reviews), 2015/04/14 17:37:15]

would the ErrorState (from shill error or lasterror) appear in the results here
as well?
if so, and if it's intended, you could modify this test case to check that
behavior as well.

[stevenjb, 2015/04/14 18:27:17]

Actually, I am going to change the code that ErrorState is only set if non-empty
to avoid having to add a lot of ErrorState: '' throughout this file
(get{Managed}Properties would have it as well). I think that is cleaner and
easier. I'll make sure that behavior is documented in the spec.

       NetworkType.ALL,
       callbackPass(function(result) {
         assertEq([{
           ConnectionState: ConnectionStateType.CONNECTED,
           Ethernet: {
             Authentication: 'None'
           },
           GUID: 'stub_ethernet_guid',
           Name: 'eth0',
           Source: 'Device',
@@ skipping 352 matching lines @@
             SignalStrength: 80
           }
         }, result);
       }));
   },
   function getStateNonExistent() {
     chrome.networkingPrivate.getState(
       'non_existent',
       callbackFail('Error.InvalidNetworkGuid'));
   },
+  function getErrorState() {
+    // Both getState and getProperties should have ErrorState set.
+    chrome.networkingPrivate.getState(
+      'stub_wifi1_guid',
+      function(result) {
+        assertEq('TestErrorState', result.ErrorState);
+        chrome.networkingPrivate.getProperties(
+          'stub_wifi1_guid',
+          callbackPass(function(result2) {
+            assertEq('TestErrorState', result2.ErrorState);
+          }));
+      });
+  },
   function onNetworksChangedEventConnect() {
     var network = 'stub_wifi2_guid';
     var done = chrome.test.callbackAdded();
     var expectedStates = [ConnectionStateType.CONNECTED];
     var listener =
         new privateHelpers.watchForStateChanges(network, expectedStates, done);
     chrome.networkingPrivate.startConnect(network, callbackPass());
   },
   function onNetworksChangedEventDisconnect() {
     var network = 'stub_wifi1_guid';
@@ skipping 85 matching lines @@
         new privateHelpers.watchForCaptivePortalState(
             'wifi_guid', 'Online', done);
     chrome.test.sendMessage('notifyPortalDetectorObservers');
   },
 ];
 
 var testToRun = window.location.search.substring(1);
 chrome.test.runTests(availableTests.filter(function(op) {
   return op.name == testToRun;
 }));