Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 1043343002: Use networkingPrivate.startConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_cellular
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/chromeos/internet_options_handler.h" 5 #include "chrome/browser/ui/webui/options/chromeos/internet_options_handler.h"
6 6
7 #include <ctype.h> 7 #include <ctype.h>
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 const char kSetVPNProvidersFunction[] = "options.VPNProviders.setProviders"; 84 const char kSetVPNProvidersFunction[] = "options.VPNProviders.setProviders";
85 const char kRefreshNetworkDataFunction[] = 85 const char kRefreshNetworkDataFunction[] =
86 "options.network.NetworkList.refreshNetworkData"; 86 "options.network.NetworkList.refreshNetworkData";
87 const char kUpdateConnectionDataFunction[] = 87 const char kUpdateConnectionDataFunction[] =
88 "options.internet.DetailsInternetPage.updateConnectionData"; 88 "options.internet.DetailsInternetPage.updateConnectionData";
89 89
90 // JS methods to show additional UI. 90 // JS methods to show additional UI.
91 const char kShowMorePlanInfoMessage[] = "showMorePlanInfo"; 91 const char kShowMorePlanInfoMessage[] = "showMorePlanInfo";
92 const char kSimOperationMessage[] = "simOperation"; 92 const char kSimOperationMessage[] = "simOperation";
93 93
94 // TODO(stevenjb): Replace these with the matching networkingPrivate methods.
95 // crbug.com/279351.
96 const char kStartConnectMessage[] = "startConnect";
97
98 // TODO(stevenjb): Deprecate this once we handle events in the JS. 94 // TODO(stevenjb): Deprecate this once we handle events in the JS.
99 const char kSetNetworkGuidMessage[] = "setNetworkGuid"; 95 const char kSetNetworkGuidMessage[] = "setNetworkGuid";
100 96
101 // TODO(stevenjb): Deprecate these and integrate with settings Web UI. 97 // TODO(stevenjb): Deprecate these and integrate with settings Web UI.
102 const char kAddVPNConnectionMessage[] = "addVPNConnection"; 98 const char kAddVPNConnectionMessage[] = "addVPNConnection";
103 const char kAddNonVPNConnectionMessage[] = "addNonVPNConnection"; 99 const char kAddNonVPNConnectionMessage[] = "addNonVPNConnection";
104 const char kConfigureNetworkMessage[] = "configureNetwork"; 100 const char kConfigureNetworkMessage[] = "configureNetwork";
105 101
106 const char kLoadVPNProviders[] = "loadVPNProviders"; 102 const char kLoadVPNProviders[] = "loadVPNProviders";
107 103
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 base::Bind(&InternetOptionsHandler::SimOperationCallback, 249 base::Bind(&InternetOptionsHandler::SimOperationCallback,
254 base::Unretained(this))); 250 base::Unretained(this)));
255 web_ui()->RegisterMessageCallback( 251 web_ui()->RegisterMessageCallback(
256 kLoadVPNProviders, 252 kLoadVPNProviders,
257 base::Bind(&InternetOptionsHandler::LoadVPNProvidersCallback, 253 base::Bind(&InternetOptionsHandler::LoadVPNProvidersCallback,
258 base::Unretained(this))); 254 base::Unretained(this)));
259 255
260 web_ui()->RegisterMessageCallback(kSetNetworkGuidMessage, 256 web_ui()->RegisterMessageCallback(kSetNetworkGuidMessage,
261 base::Bind(&InternetOptionsHandler::SetNetworkGuidCallback, 257 base::Bind(&InternetOptionsHandler::SetNetworkGuidCallback,
262 base::Unretained(this))); 258 base::Unretained(this)));
263
264 // networkingPrivate methods
265 web_ui()->RegisterMessageCallback(kStartConnectMessage,
266 base::Bind(&InternetOptionsHandler::StartConnectCallback,
267 base::Unretained(this)));
268 } 259 }
269 260
270 void InternetOptionsHandler::OnExtensionLoaded( 261 void InternetOptionsHandler::OnExtensionLoaded(
271 content::BrowserContext* browser_context, 262 content::BrowserContext* browser_context,
272 const extensions::Extension* extension) { 263 const extensions::Extension* extension) {
273 if (IsVPNProvider(extension)) 264 if (IsVPNProvider(extension))
274 UpdateVPNProviders(); 265 UpdateVPNProviders();
275 } 266 }
276 267
277 void InternetOptionsHandler::OnExtensionUnloaded( 268 void InternetOptionsHandler::OnExtensionUnloaded(
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 void InternetOptionsHandler::SetNetworkGuidCallback( 330 void InternetOptionsHandler::SetNetworkGuidCallback(
340 const base::ListValue* args) { 331 const base::ListValue* args) {
341 std::string guid; 332 std::string guid;
342 if (args->GetSize() != 1 || !args->GetString(0, &guid)) { 333 if (args->GetSize() != 1 || !args->GetString(0, &guid)) {
343 NOTREACHED(); 334 NOTREACHED();
344 return; 335 return;
345 } 336 }
346 details_guid_ = guid; 337 details_guid_ = guid;
347 } 338 }
348 339
349
350 ////////////////////////////////////////////////////////////////////////////////
351 // networkingPrivate implementation methods. TODO(stevenjb): Use the
352 // networkingPrivate API directly in the settings JS and deprecate these
353 // methods. crbug.com/279351.
354
355 void InternetOptionsHandler::StartConnectCallback(const base::ListValue* args) {
356 std::string guid;
357 if (!args->GetString(0, &guid)) {
358 NOTREACHED();
359 return;
360 }
361 std::string service_path = ServicePathFromGuid(guid);
362 if (!service_path.empty())
363 ui::NetworkConnect::Get()->ConnectToNetwork(service_path);
364 }
365
366 //////////////////////////////////////////////////////////////////////////////// 340 ////////////////////////////////////////////////////////////////////////////////
367 341
368 void InternetOptionsHandler::UpdateVPNProviders() { 342 void InternetOptionsHandler::UpdateVPNProviders() {
369 extensions::ExtensionRegistry* const registry = 343 extensions::ExtensionRegistry* const registry =
370 GetExtensionRegistryForPrimaryUser(); 344 GetExtensionRegistryForPrimaryUser();
371 345
372 base::ListValue vpn_providers; 346 base::ListValue vpn_providers;
373 const extensions::ExtensionSet& extensions = registry->enabled_extensions(); 347 const extensions::ExtensionSet& extensions = registry->enabled_extensions();
374 for (const auto& extension : extensions) { 348 for (const auto& extension : extensions) {
375 if (IsVPNProvider(extension.get())) { 349 if (IsVPNProvider(extension.get())) {
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 dictionary->SetBoolean( 595 dictionary->SetBoolean(
622 kTagWimaxAvailable, 596 kTagWimaxAvailable,
623 handler->IsTechnologyAvailable(NetworkTypePattern::Wimax())); 597 handler->IsTechnologyAvailable(NetworkTypePattern::Wimax()));
624 dictionary->SetBoolean( 598 dictionary->SetBoolean(
625 kTagWimaxEnabled, 599 kTagWimaxEnabled,
626 handler->IsTechnologyEnabled(NetworkTypePattern::Wimax())); 600 handler->IsTechnologyEnabled(NetworkTypePattern::Wimax()));
627 } 601 }
628 602
629 } // namespace options 603 } // namespace options
630 } // namespace chromeos 604 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698