Use networkingPrivate.startConnect

ui/chromeos/network/network_connect.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/chromeos/network/network_connect.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 189 matching lines @@
 
 // This handles connect failures that are a direct result of a user initiated
 // connect request and result in a new UI being shown. Note: notifications are
 // handled by NetworkStateNotifier.
 void NetworkConnectImpl::OnConnectFailed(
     const std::string& service_path,
     const std::string& error_name,
     scoped_ptr<base::DictionaryValue> error_data) {
   NET_LOG_ERROR("Connect Failed: " + error_name, service_path);
 
-  // If a new connect attempt canceled this connect, or a connect attempt to
-  // the same network is in progress, no need to notify the user here since they
-  // will be notified when the new or existing attempt completes.
-  if (error_name == NetworkConnectionHandler::kErrorConnectCanceled ||
-      error_name == NetworkConnectionHandler::kErrorConnecting) {
-    return;
-  }

[stevenjb, 2015/04/01 00:20:47]

This early exit isn't necessary and just confuses things.

-
-  // Already connected to the network, show the settings UI for the network.
-  if (error_name == NetworkConnectionHandler::kErrorConnected) {
-    ShowNetworkSettingsForPath(service_path);
-    return;
-  }

[stevenjb, 2015/04/01 00:20:48]

This shouldn't happen, we check for connected networks in the UI.

-
   if (error_name == NetworkConnectionHandler::kErrorBadPassphrase ||
       error_name == NetworkConnectionHandler::kErrorPassphraseRequired ||
       error_name == NetworkConnectionHandler::kErrorConfigurationRequired ||
       error_name == NetworkConnectionHandler::kErrorAuthenticationRequired) {
     HandleUnconfiguredNetwork(service_path);
     return;
   }

[stevenjb, 2015/04/01 00:20:48]

This shouldn't happen, we check the 'Configured' state before attempting a
connect. If it does we will still see an error notification (handled in
NetworkStateNotifier).

 
   if (error_name == NetworkConnectionHandler::kErrorCertificateRequired) {
     if (!delegate_->ShowEnrollNetwork(service_path))
       HandleUnconfiguredNetwork(service_path);
     return;
   }

[stevenjb, 2015/04/01 00:20:48]

Same here.

 
   // Only show a configure dialog if there was a ConnectFailed error. The dialog
   // allows the user to request a new connect attempt or cancel. Note: a
   // notification may also be displayed by NetworkStateNotifier in this case.
   if (error_name == NetworkConnectionHandler::kErrorConnectFailed)
     HandleUnconfiguredNetwork(service_path);

[stevenjb, 2015/04/01 00:20:48]

Edge case. The Settings UI will no longer automatically open the configuration
UI when this happens, but a notification will still occur, which seems fine.

 
   // Notifications for other connect failures are handled by
   // NetworkStateNotifier, so no need to do anything else here.
 }
 
 void NetworkConnectImpl::OnConnectSucceeded(const std::string& service_path) {
   NET_LOG_USER("Connect Succeeded", service_path);
   network_state_notifier_->RemoveConnectNotification();
 }
 
 // If |check_error_state| is true, error state for the network is checked,
 // otherwise any current error state is ignored (e.g. for recently configured
 // networks or repeat connect attempts).
 void NetworkConnectImpl::CallConnectToNetwork(const std::string& service_path,
                                               bool check_error_state) {
-  network_state_notifier_->RemoveConnectNotification();

[stevenjb, 2015/04/01 00:20:48]

Moved to NetworkStateNotifier any time a new connection attempt occurs.

   NetworkHandler::Get()->network_connection_handler()->ConnectToNetwork(
       service_path, base::Bind(&NetworkConnectImpl::OnConnectSucceeded,
                                weak_factory_.GetWeakPtr(), service_path),
       base::Bind(&NetworkConnectImpl::OnConnectFailed,
                  weak_factory_.GetWeakPtr(), service_path),
       check_error_state);
 }
 
 void NetworkConnectImpl::OnActivateFailed(
     const std::string& service_path,
@@ skipping 376 matching lines @@
   return g_network_connect;
 }
 
 NetworkConnect::NetworkConnect() {
 }
 
 NetworkConnect::~NetworkConnect() {
 }
 
 }  // namespace ui