Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/apps/app_window_browsertest.cc

Issue 104333002: Disable TestRestoreGeometryCacheChange on all platforms, as it also flakes on WinXP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/shell_window_geometry_cache.h" 5 #include "apps/shell_window_geometry_cache.h"
6 #include "chrome/browser/apps/app_browsertest_util.h" 6 #include "chrome/browser/apps/app_browsertest_util.h"
7 #include "chrome/browser/extensions/extension_test_message_listener.h" 7 #include "chrome/browser/extensions/extension_test_message_listener.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/extensions/application_launch.h" 10 #include "chrome/browser/ui/extensions/application_launch.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } 108 }
109 109
110 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestRestore) { 110 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestRestore) {
111 ASSERT_TRUE(RunAppWindowAPITest("testRestore")) << message_; 111 ASSERT_TRUE(RunAppWindowAPITest("testRestore")) << message_;
112 } 112 }
113 113
114 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestRestoreAfterClose) { 114 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestRestoreAfterClose) {
115 ASSERT_TRUE(RunAppWindowAPITest("testRestoreAfterClose")) << message_; 115 ASSERT_TRUE(RunAppWindowAPITest("testRestoreAfterClose")) << message_;
116 } 116 }
117 117
118 // Flaky failures on mac_rel, see http://crbug.com/324915 118 // Flaky failures on mac_rel and WinXP, see http://crbug.com/324915.
119 #if defined(OS_MACOSX) 119 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestRestoreGeometryCacheChange) {
120 #define MAYBE_TestRestoreGeometryCacheChange DISABLED_TestRestoreGeometryCacheCh ange
121 #else
122 #define MAYBE_TestRestoreGeometryCacheChange TestRestoreGeometryCacheChange
123 #endif
124 IN_PROC_BROWSER_TEST_F(AppWindowAPI, MAYBE_TestRestoreGeometryCacheChange) {
125 // This test is similar to the other AppWindowAPI tests except that at some 120 // This test is similar to the other AppWindowAPI tests except that at some
126 // point the app will send a 'ListenGeometryChange' message at which point the 121 // point the app will send a 'ListenGeometryChange' message at which point the
127 // test will check if the geometry cache entry for the test window has 122 // test will check if the geometry cache entry for the test window has
128 // changed. When the change happens, the test will let the app know so it can 123 // changed. When the change happens, the test will let the app know so it can
129 // continue running. 124 // continue running.
130 ExtensionTestMessageListener launched_listener("Launched", true); 125 ExtensionTestMessageListener launched_listener("Launched", true);
131 126
132 content::WindowedNotificationObserver app_loaded_observer( 127 content::WindowedNotificationObserver app_loaded_observer(
133 content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME, 128 content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
134 content::NotificationService::AllSources()); 129 content::NotificationService::AllSources());
(...skipping 21 matching lines...) Expand all
156 geo_change_helper.WaitForEntirelyChanged(); 151 geo_change_helper.WaitForEntirelyChanged();
157 152
158 ResultCatcher catcher; 153 ResultCatcher catcher;
159 geometry_listener.Reply(""); 154 geometry_listener.Reply("");
160 ASSERT_TRUE(catcher.GetNextResult()); 155 ASSERT_TRUE(catcher.GetNextResult());
161 } 156 }
162 157
163 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestSizeConstraints) { 158 IN_PROC_BROWSER_TEST_F(AppWindowAPI, DISABLED_TestSizeConstraints) {
164 ASSERT_TRUE(RunAppWindowAPITest("testSizeConstraints")) << message_; 159 ASSERT_TRUE(RunAppWindowAPITest("testSizeConstraints")) << message_;
165 } 160 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698