Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1043263004: Basic hookup for distiller feedback (Closed)

Created:
5 years, 8 months ago by mdjones
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, wychen
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@rebase-html-feedback
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Basic hookup for distiller feedback This change adds actions for the distiller feedback form buttons which now record UMA stats. BUG= Committed: https://crrev.com/b18ec338c746ef4bff4686cd7b3395d1ebe9aec7 Cr-Commit-Position: refs/heads/master@{#323752}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M components/dom_distiller/content/dom_distiller_viewer_source.cc View 1 3 chunks +9 lines, -5 lines 3 comments Download
M components/dom_distiller/core/javascript/dom_distiller_viewer.js View 2 chunks +30 lines, -0 lines 0 comments Download
M components/dom_distiller/core/url_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/dom_distiller/core/url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mdjones
Please appreciate the reuse of "image AJAX".
5 years, 8 months ago (2015-03-31 23:34:13 UTC) #2
cjhopman
lgtm
5 years, 8 months ago (2015-03-31 23:41:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043263004/20001
5 years, 8 months ago (2015-04-03 15:20:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 16:25:04 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b18ec338c746ef4bff4686cd7b3395d1ebe9aec7 Cr-Commit-Position: refs/heads/master@{#323752}
5 years, 8 months ago (2015-04-03 20:38:09 UTC) #8
wychen
https://codereview.chromium.org/1043263004/diff/20001/components/dom_distiller/content/dom_distiller_viewer_source.cc File components/dom_distiller/content/dom_distiller_viewer_source.cc (right): https://codereview.chromium.org/1043263004/diff/20001/components/dom_distiller/content/dom_distiller_viewer_source.cc#newcode320 components/dom_distiller/content/dom_distiller_viewer_source.cc:320: FeedbackReporter::ReportQuality(false); Do we need "callback.Run(NULL)" like kViewerViewOriginalPath above?
5 years, 8 months ago (2015-04-27 21:18:49 UTC) #10
cjhopman
https://codereview.chromium.org/1043263004/diff/20001/components/dom_distiller/content/dom_distiller_viewer_source.cc File components/dom_distiller/content/dom_distiller_viewer_source.cc (right): https://codereview.chromium.org/1043263004/diff/20001/components/dom_distiller/content/dom_distiller_viewer_source.cc#newcode320 components/dom_distiller/content/dom_distiller_viewer_source.cc:320: FeedbackReporter::ReportQuality(false); On 2015/04/27 21:18:49, wychen wrote: > Do we ...
5 years, 8 months ago (2015-04-27 21:22:57 UTC) #11
mdjones
5 years, 8 months ago (2015-04-27 22:09:02 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/1043263004/diff/20001/components/dom_distille...
File components/dom_distiller/content/dom_distiller_viewer_source.cc (right):

https://codereview.chromium.org/1043263004/diff/20001/components/dom_distille...
components/dom_distiller/content/dom_distiller_viewer_source.cc:320:
FeedbackReporter::ReportQuality(false);
On 2015/04/27 21:22:57, cjhopman wrote:
> On 2015/04/27 21:18:49, wychen wrote:
> > Do we need "callback.Run(NULL)" like kViewerViewOriginalPath above?
> 
> Yeah, probably. Otherwise these gets will just be hanging forever.

CL fixing this issue: https://codereview.chromium.org/1106293004

Powered by Google App Engine
This is Rietveld 408576698