Implemented AddAllocWithZoneMethod to override allocWithZone: on demand.

Implemented AddAllocWithZoneMethod to override allocWithZone: on demand.

BUG=None

Committed: https://crrev.com/064f5bfda49d041ada91fc268b64bc700f876a2d
Cr-Commit-Position: refs/heads/master@{#325092}

[Eugene But (OOO till 7-30), 2015-03-31 21:42:55]

eugenebut@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[shreyasv1, 2015-04-08 22:36:20]

shreyasv@chromium.org changed reviewers:
+ shreyasv@chromium.org

[shreyasv1, 2015-04-08 22:36:20]

lgtm

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
File ios/web/alloc_with_zone_interceptor.mm (right):

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
ios/web/alloc_with_zone_interceptor.mm:14: // Make sure allocWithZone: is not
already implemented in the target class.
|allocWithZone:|?

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
File ios/web/alloc_with_zone_interceptor_unittest.mm (right):

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
ios/web/alloc_with_zone_interceptor_unittest.mm:20: // Test class for
alloc_with_zone_interceptor functions.
Wording NIT: This is actually a Test Fixture.

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
ios/web/alloc_with_zone_interceptor_unittest.mm:26: NSZone* const kZone =
NSDefaultMallocZone();
Optional: Given that NSDefaultMallocZone returns the same NSZone for every call
(Idempotent?). Maybe just inline this?

[Eugene But (OOO till 7-30), 2015-04-08 23:02:12]

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
File ios/web/alloc_with_zone_interceptor.mm (right):

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
ios/web/alloc_with_zone_interceptor.mm:14: // Make sure allocWithZone: is not
already implemented in the target class.
On 2015/04/08 22:36:20, shreyasv1 wrote:
> |allocWithZone:|? 

Done.

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
File ios/web/alloc_with_zone_interceptor_unittest.mm (right):

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
ios/web/alloc_with_zone_interceptor_unittest.mm:20: // Test class for
alloc_with_zone_interceptor functions.
On 2015/04/08 22:36:20, shreyasv1 wrote:
> Wording NIT: This is actually a Test Fixture.

Done.

https://codereview.chromium.org/1043263003/diff/1/ios/web/alloc_with_zone_int...
ios/web/alloc_with_zone_interceptor_unittest.mm:26: NSZone* const kZone =
NSDefaultMallocZone();
On 2015/04/08 22:36:20, shreyasv1 wrote:
> Optional: Given that NSDefaultMallocZone returns the same NSZone for every
call
> (Idempotent?). Maybe just inline this?
I have kResult, having kZone seems consistent.

[stuartmorgan, 2015-04-14 13:53:07]

lgtm

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
File ios/web/alloc_with_zone_interceptor.h (right):

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
ios/web/alloc_with_zone_interceptor.h:13: // |allocWithZone:| method of |target|
Class. |target| or any of its
s/|target| or/Neither |target| nor/

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
File ios/web/alloc_with_zone_interceptor_unittest.mm (right):

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
ios/web/alloc_with_zone_interceptor_unittest.mm:32: EXPECT_NSEQ(kResult,
[CRBTestAlloc allocWithZone:kZone]);
Just to be sure the test can't give false positives, I'd suggest EXPECT_EQ-ing
the same thing before calling AddAllocWithZoneMethod.

[Eugene But (OOO till 7-30), 2015-04-14 17:51:16]

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
File ios/web/alloc_with_zone_interceptor.h (right):

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
ios/web/alloc_with_zone_interceptor.h:13: // |allocWithZone:| method of |target|
Class. |target| or any of its
On 2015/04/14 13:53:06, stuartmorgan wrote:
> s/|target| or/Neither |target| nor/

Done.

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
File ios/web/alloc_with_zone_interceptor_unittest.mm (right):

https://codereview.chromium.org/1043263003/diff/20001/ios/web/alloc_with_zone...
ios/web/alloc_with_zone_interceptor_unittest.mm:32: EXPECT_NSEQ(kResult,
[CRBTestAlloc allocWithZone:kZone]);
On 2015/04/14 13:53:06, stuartmorgan wrote:
> Just to be sure the test can't give false positives, I'd suggest EXPECT_EQ-ing
> the same thing before calling AddAllocWithZoneMethod.

Done.

[Eugene But (OOO till 7-30), 2015-04-14 17:51:19]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-04-14 17:51:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
shreyasv@chromium.org, stuartmorgan@chromium.org
Link to the patchset: https://codereview.chromium.org/1043263003/#ps40001
(title: "Resolved Stuart's review comments")

[commit-bot: I haz the power, 2015-04-14 17:52:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1043263003/40001

[commit-bot: I haz the power, 2015-04-14 18:35:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-14 18:36:15]

Patchset 3 (id:??) landed as
https://crrev.com/064f5bfda49d041ada91fc268b64bc700f876a2d
Cr-Commit-Position: refs/heads/master@{#325092}