Upstream most of ios/web/net

Upstream most of ios/web/net

This upstreams the bulk of ios/web/net, except for the network clients
which will be a follow-up CL.

Includes some necessary supporting files from other parts of ios/web/

BUG=464810
Committed: https://crrev.com/d7f6a672d1d0487803be8a7984e52f06f648fe4c
Cr-Commit-Position: refs/heads/master@{#323122}

[stuartmorgan, 2015-03-31 18:40:04]

stuartmorgan@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-03-31 20:11:09]

lgtm

https://codereview.chromium.org/1043243003/diff/1/ios/web/browser_state.cc
File ios/web/browser_state.cc (right):

https://codereview.chromium.org/1043243003/diff/1/ios/web/browser_state.cc#ne...
ios/web/browser_state.cc:26: scoped_refptr<CertificatePolicyCache>
policy_cache_;
C++ Style Guide says: Make data members private, unless they are static const.

Looks like it will be reasonable to make CertificatePolicyCacheHandle a struct
rather than class,

https://codereview.chromium.org/1043243003/diff/1/ios/web/net/request_tracker...
File ios/web/net/request_tracker_factory_impl.h (right):

https://codereview.chromium.org/1043243003/diff/1/ios/web/net/request_tracker...
ios/web/net/request_tracker_factory_impl.h:19: virtual
~RequestTrackerFactoryImpl();
override

[stuartmorgan, 2015-03-31 21:08:13]

https://codereview.chromium.org/1043243003/diff/1/ios/web/browser_state.cc
File ios/web/browser_state.cc (right):

https://codereview.chromium.org/1043243003/diff/1/ios/web/browser_state.cc#ne...
ios/web/browser_state.cc:26: scoped_refptr<CertificatePolicyCache>
policy_cache_;
On 2015/03/31 20:11:09, eugenebut wrote:
> C++ Style Guide says: Make data members private, unless they are static const.
> 
> Looks like it will be reasonable to make CertificatePolicyCacheHandle a struct
> rather than class,

Done.

https://codereview.chromium.org/1043243003/diff/1/ios/web/net/request_tracker...
File ios/web/net/request_tracker_factory_impl.h (right):

https://codereview.chromium.org/1043243003/diff/1/ios/web/net/request_tracker...
ios/web/net/request_tracker_factory_impl.h:19: virtual
~RequestTrackerFactoryImpl();
On 2015/03/31 20:11:09, eugenebut wrote:
> override

Done. This revealed a missing virtual destructor on the interface class, so I
added that.

[stuartmorgan, 2015-03-31 21:34:32]

The CQ bit was checked by stuartmorgan@chromium.org

[stuartmorgan, 2015-03-31 21:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1043243003/#ps40001
(title: "Remove accidentally-added clients")

[commit-bot: I haz the power, 2015-03-31 21:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1043243003/40001

[commit-bot: I haz the power, 2015-03-31 22:01:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-31 22:01:54]

Patchset 3 (id:??) landed as
https://crrev.com/d7f6a672d1d0487803be8a7984e52f06f648fe4c
Cr-Commit-Position: refs/heads/master@{#323122}