Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 1043233002: Disable chromium_builder_tests entries for chromecast. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable chromium_builder_tests entries for chromecast. R=thakis@chromium.org BUG=472150 Committed: https://crrev.com/ab581451d0bd05433afeb7e953bb1fcf229915bb Cr-Commit-Position: refs/heads/master@{#323072}

Patch Set 1 #

Total comments: 2

Patch Set 2 : condition individual tests in chromium_swarm_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M build/all.gyp View 1 4 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
gunsch
5 years, 8 months ago (2015-03-31 16:24:18 UTC) #1
Nico
lgtm https://codereview.chromium.org/1043233002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/1043233002/diff/1/build/all.gyp#newcode423 build/all.gyp:423: ['test_isolation_mode != "noop" and chromecast==0', { Does chromecast ...
5 years, 8 months ago (2015-03-31 16:27:19 UTC) #2
gunsch
https://codereview.chromium.org/1043233002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/1043233002/diff/1/build/all.gyp#newcode423 build/all.gyp:423: ['test_isolation_mode != "noop" and chromecast==0', { On 2015/03/31 16:27:19, ...
5 years, 8 months ago (2015-03-31 16:34:41 UTC) #3
Nico
lgtm!
5 years, 8 months ago (2015-03-31 16:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043233002/20001
5 years, 8 months ago (2015-03-31 16:42:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 18:24:06 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ab581451d0bd05433afeb7e953bb1fcf229915bb Cr-Commit-Position: refs/heads/master@{#323072}
5 years, 8 months ago (2015-03-31 18:24:41 UTC) #8
gunsch
5 years, 8 months ago (2015-04-01 15:43:41 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1052563004/ by gunsch@chromium.org.

The reason for reverting is: Chromecast doesn't actually need to build
chromium_builder_tests, so reverting to remove the introduced complexity.

Fixed more correctly in: https://codereview.chromium.org/1049333002/ .

Powered by Google App Engine
This is Rietveld 408576698