Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1043213003: Remove redundant serviceworker/cache-* tests (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 8 months ago
Reviewers:
jkarlin
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove redundant serviceworker/cache-* tests The tests were moved to cachestorage/ and made generic to cover window, worker, and serviceworker cases, so coverage is identical. BUG=439389 R=jkarlin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192898

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : Re-add fetch-status.php, used by fetch tests in sibling dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1576 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-add.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-add-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-delete.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-delete-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-match.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-match-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-put.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-put-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-storage.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-storage-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-storage-keys.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/cache-storage-match.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-add-worker.js View 1 chunk +0 lines, -147 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-delete-worker.js View 1 chunk +0 lines, -116 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js View 1 chunk +0 lines, -497 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js View 1 chunk +0 lines, -323 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-storage-keys-worker.js View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-storage-match-worker.js View 1 chunk +0 lines, -119 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/cache-storage-worker.js View 1 chunk +0 lines, -187 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jsbell
jkarlin@ - please take a look?
5 years, 8 months ago (2015-03-31 17:46:47 UTC) #1
jsbell
https://codereview.chromium.org/1043213003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (left): https://codereview.chromium.org/1043213003/diff/1/LayoutTests/TestExpectations#oldcode1537 LayoutTests/TestExpectations:1537: crbug.com/433727 [ XP ] http/tests/cachestorage/window/cache-put.html [ Pass Timeout ] ...
5 years, 8 months ago (2015-03-31 17:48:15 UTC) #2
jkarlin
lgtm
5 years, 8 months ago (2015-03-31 17:53:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043213003/20001
5 years, 8 months ago (2015-03-31 22:52:38 UTC) #6
jsbell
On 2015/03/31 22:52:38, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-01 00:14:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043213003/40001
5 years, 8 months ago (2015-04-01 00:18:42 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 03:02:43 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192898

Powered by Google App Engine
This is Rietveld 408576698