Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 1043173003: [DevTools] Move Page and Emulation handlers to RenderFrameHostImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix non-debug-devtools compilation Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index 599962d3c2694b86e680c57001de217d53a95ec6..18082118e77d5ed390e831a3ad2702d324ccde65 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -12,8 +12,6 @@
#include "base/memory/scoped_ptr.h"
#include "content/browser/devtools/ipc_devtools_agent_host.h"
#include "content/common/content_export.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_observer.h"
namespace cc {
@@ -45,8 +43,7 @@ namespace tracing { class TracingHandler; }
class CONTENT_EXPORT RenderFrameDevToolsAgentHost
: public IPCDevToolsAgentHost,
- private WebContentsObserver,
- public NotificationObserver {
+ private WebContentsObserver {
public:
static void AddAllAgentHosts(DevToolsAgentHost::List* result);
@@ -104,11 +101,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
const GURL& url,
ui::PageTransition transition_type) override;
- // NotificationObserver overrides:
- void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) override;
-
void DisconnectRenderFrameHost();
void ConnectRenderFrameHost(RenderFrameHost* rvh);
void ReattachToRenderFrameHost(RenderFrameHost* rvh);
@@ -145,7 +137,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
#if defined(OS_ANDROID)
scoped_ptr<PowerSaveBlockerImpl> power_save_blocker_;
#endif
- NotificationRegistrar registrar_;
bool reattaching_;
DISALLOW_COPY_AND_ASSIGN(RenderFrameDevToolsAgentHost);
« no previous file with comments | « content/browser/devtools/protocol/page_handler.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698