Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 1043173003: [DevTools] Move Page and Emulation handlers to RenderFrameHostImpl. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
pfeldman, nasko
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Page and Emulation handlers to RenderFrameHostImpl. BUG=470453 Committed: https://crrev.com/38087a4234ddd8bdab979dda6c32e37f281ef83a Cr-Commit-Position: refs/heads/master@{#324228}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : WC->RFH #

Patch Set 4 : cleanup #

Patch Set 5 : Fix non-debug-devtools compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -129 lines) Patch
M content/browser/devtools/protocol/color_picker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/color_picker.cc View 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/emulation_handler.h View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 1 2 3 4 6 chunks +27 lines, -34 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 1 2 5 chunks +15 lines, -6 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 2 13 chunks +54 lines, -36 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 4 chunks +1 line, -10 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 9 chunks +31 lines, -36 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
dgozman
Take a look please.
5 years, 8 months ago (2015-03-31 14:20:53 UTC) #2
nasko
drive-by comment https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc File content/browser/devtools/protocol/emulation_handler.cc (right): https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc#newcode185 content/browser/devtools/protocol/emulation_handler.cc:185: // WebContents without RenderViewHost. WebContentsImpl::GetMainFrame()->GetRenderWidgetHost()?
5 years, 8 months ago (2015-03-31 14:43:36 UTC) #4
dgozman
https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc File content/browser/devtools/protocol/emulation_handler.cc (right): https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc#newcode185 content/browser/devtools/protocol/emulation_handler.cc:185: // WebContents without RenderViewHost. On 2015/03/31 14:43:36, nasko (out ...
5 years, 8 months ago (2015-03-31 15:05:23 UTC) #5
nasko
On 2015/03/31 15:05:23, dgozman wrote: > https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc > File content/browser/devtools/protocol/emulation_handler.cc (right): > > https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc#newcode185 > ...
5 years, 8 months ago (2015-03-31 15:18:00 UTC) #6
dgozman
https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc File content/browser/devtools/protocol/emulation_handler.cc (right): https://codereview.chromium.org/1043173003/diff/1/content/browser/devtools/protocol/emulation_handler.cc#newcode185 content/browser/devtools/protocol/emulation_handler.cc:185: // WebContents without RenderViewHost. On 2015/03/31 14:43:36, nasko (out ...
5 years, 8 months ago (2015-03-31 16:44:59 UTC) #7
pfeldman
lgtm
5 years, 8 months ago (2015-04-01 13:37:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043173003/20001
5 years, 8 months ago (2015-04-01 14:11:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/41950)
5 years, 8 months ago (2015-04-01 15:52:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043173003/60001
5 years, 8 months ago (2015-04-08 10:41:25 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/25368)
5 years, 8 months ago (2015-04-08 10:58:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043173003/80001
5 years, 8 months ago (2015-04-08 12:25:20 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-08 15:04:31 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 16:05:34 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/38087a4234ddd8bdab979dda6c32e37f281ef83a
Cr-Commit-Position: refs/heads/master@{#324228}

Powered by Google App Engine
This is Rietveld 408576698