Issue 1043163002: Refactor of password generation manager unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1043163002: Refactor of password generation manager unittests. (Closed)

Created:
5 years, 8 months ago by melandory

Modified:
5 years, 8 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Refactor of password generation manager unittests. BUG=450583 R=vabr@chromium.org Committed: https://crrev.com/ee78b199ff953accf968ba975c6562e9c87b8cb6 Cr-Commit-Position: refs/heads/master@{#323021}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -27 lines)			Patch
	M	components/password_manager/core/browser/password_generation_manager_unittest.cc	View		7 chunks	+23 lines, -27 lines	0 comments	Download

Total messages: 6 (1 generated)

vabr (Chromium)

LGTM, Thanks for the steady stream of improvements! Cheers, Vaclav

5 years, 8 months ago (2015-03-31 12:33:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043163002/1

5 years, 8 months ago (2015-03-31 12:34:16 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 12:47:20 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ee78b199ff953accf968ba975c6562e9c87b8cb6
Cr-Commit-Position: refs/heads/master@{#323021}