Issue 104313002: Use HeapProfiler::FindObjectById when searching for node

Issue 104313002: Use HeapProfiler::FindObjectById when searching for node (Closed)

Created:
7 years ago by yurys

Modified:
7 years ago

Reviewers:
alph, loislo

CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use HeapProfiler::FindObjectById when searching for node v8::HeapGraphNode::GetHeapValue is going to be deprecated soon. This change switches heap profiler implementation in Blink to FindObjectById which doesn't depend on a particular heap snapshot. BUG=324769 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164224

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments addressed #

Patch Set 3 : Rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -16 lines)			Patch
M	Source/bindings/v8/ScriptProfiler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/v8/ScriptProfiler.cpp	View	1 2	2 chunks	+9 lines, -16 lines	0 comments	Download
M	Source/core/inspector/InspectorHeapProfilerAgent.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

This change depends on V8's change: https://codereview.chromium.org/93843004/

7 years ago (2013-12-04 10:12:19 UTC) #1

alph

lgtm https://codereview.chromium.org/104313002/diff/1/Source/bindings/v8/ScriptProfiler.cpp File Source/bindings/v8/ScriptProfiler.cpp (right): https://codereview.chromium.org/104313002/diff/1/Source/bindings/v8/ScriptProfiler.cpp#newcode141 Source/bindings/v8/ScriptProfiler.cpp:141: v8::HeapProfiler* profiler = isolate->GetHeapProfiler(); Just curious, why do ...

7 years ago (2013-12-04 10:18:41 UTC) #2

yurys

https://codereview.chromium.org/104313002/diff/1/Source/bindings/v8/ScriptProfiler.cpp File Source/bindings/v8/ScriptProfiler.cpp (right): https://codereview.chromium.org/104313002/diff/1/Source/bindings/v8/ScriptProfiler.cpp#newcode141 Source/bindings/v8/ScriptProfiler.cpp:141: v8::HeapProfiler* profiler = isolate->GetHeapProfiler(); On 2013/12/04 10:18:41, alph wrote: ...

7 years ago (2013-12-04 11:33:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/104313002/40001

7 years ago (2013-12-20 08:11:19 UTC) #4

Message was sent while issue was closed.

Change committed as 164224

Expand Messages | Collapse Messages