Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: shell/child_process_host.cc

Issue 1043123004: Shell: Remove various child process type stuff. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/child_process_host.cc
diff --git a/shell/child_process_host.cc b/shell/child_process_host.cc
index 4ead9ccba9bd8fa8898ac9e0a90808f82a523e5a..13a52b5b81c2f36fde02a4d5e204c7a16f160e7a 100644
--- a/shell/child_process_host.cc
+++ b/shell/child_process_host.cc
@@ -12,7 +12,6 @@
#include "base/macros.h"
#include "base/process/kill.h"
#include "base/process/launch.h"
-#include "base/strings/string_number_conversions.h"
#include "base/task_runner.h"
#include "base/task_runner_util.h"
#include "shell/context.h"
@@ -21,10 +20,8 @@
namespace mojo {
namespace shell {
-ChildProcessHost::ChildProcessHost(Context* context,
- Delegate* delegate,
- ChildProcess::Type type)
- : context_(context), delegate_(delegate), type_(type) {
+ChildProcessHost::ChildProcessHost(Context* context, Delegate* delegate)
+ : context_(context), delegate_(delegate) {
DCHECK(delegate);
platform_channel_ = platform_channel_pair_.PassServerHandle();
CHECK(platform_channel_.is_valid());
@@ -67,8 +64,7 @@ bool ChildProcessHost::DoLaunch() {
base::CommandLine child_command_line(parent_command_line->GetProgram());
child_command_line.CopySwitchesFrom(*parent_command_line, kForwardSwitches,
arraysize(kForwardSwitches));
- child_command_line.AppendSwitchASCII(
- switches::kChildProcessType, base::IntToString(static_cast<int>(type_)));
+ child_command_line.AppendSwitch(switches::kChildProcess);
embedder::HandlePassingInformation handle_passing_info;
platform_channel_pair_.PrepareToPassClientHandleToChildProcess(

Powered by Google App Engine
This is Rietveld 408576698