Issue 1043123004: Shell: Remove various child process type stuff.

Issue 1043123004: Shell: Remove various child process type stuff. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Shell: Remove various child process type stuff. Another intermediate step towards simplification.... R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/815417dbde3992bda1d7a089ea093dfb2899559f

Patch Set 2 : NULL -> nullptr #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -53 lines)			Patch
M	shell/app_child_process.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	shell/app_child_process_host.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	shell/app_child_process_host.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	shell/child_process.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	shell/child_process.cc	View		2 chunks	+10 lines, -25 lines	0 comments	Download
M	shell/child_process_host.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	shell/child_process_host.cc	View		3 chunks	+3 lines, -7 lines	0 comments	Download
M	shell/shell_test_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	shell/switches.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	shell/switches.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/1043123004/diff/1/shell/app_child_process_host.cc File shell/app_child_process_host.cc (right): https://codereview.chromium.org/1043123004/diff/1/shell/app_child_process_host.cc#newcode19 shell/app_child_process_host.cc:19: : ChildProcessHost(context, this), channel_info_(NULL) { nullptr

5 years, 8 months ago (2015-03-31 18:00:24 UTC) #2

viettrungluu

Thanks. On 2015/03/31 18:00:24, jamesr wrote: > lgtm > > https://codereview.chromium.org/1043123004/diff/1/shell/app_child_process_host.cc > File shell/app_child_process_host.cc (right): ...

5 years, 8 months ago (2015-03-31 18:08:02 UTC) #3

viettrungluu

5 years, 8 months ago (2015-03-31 18:08:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
815417dbde3992bda1d7a089ea093dfb2899559f (presubmit successful).

Expand Messages | Collapse Messages