Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1043103003: [BackgroundSync] Track syncManager usage (Closed)

Created:
5 years, 8 months ago by jkarlin
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@netinfo_usage
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[BackgroundSync] Track syncManager usage Downstream of: https://codereview.chromium.org/1049743002/ BUG=449443 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192884

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 2 comments Download
M Source/modules/background_sync/ServiceWorkerRegistrationSync.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarlin
pdr: ptal at everything, thanks!
5 years, 8 months ago (2015-03-31 15:02:30 UTC) #2
pdr.
LGTM with or without my suggestion. https://codereview.chromium.org/1043103003/diff/1/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1043103003/diff/1/Source/core/frame/UseCounter.h#newcode681 Source/core/frame/UseCounter.h:681: BackgroundSync = 745, ...
5 years, 8 months ago (2015-03-31 18:46:44 UTC) #3
jkarlin
Thanks! https://codereview.chromium.org/1043103003/diff/1/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1043103003/diff/1/Source/core/frame/UseCounter.h#newcode681 Source/core/frame/UseCounter.h:681: BackgroundSync = 745, On 2015/03/31 18:46:44, pdr wrote: ...
5 years, 8 months ago (2015-03-31 18:57:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043103003/1
5 years, 8 months ago (2015-03-31 22:14:09 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 23:47:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192884

Powered by Google App Engine
This is Rietveld 408576698