Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1043023002: Revert of Revert of Fix text clipping in CompositorFrameTime Display (Closed)

Created:
5 years, 8 months ago by jianli
Modified:
5 years, 8 months ago
Reviewers:
danakj, patro
CC:
ashejole_chromium.org, chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Fix text clipping in CompositorFrameTime Display (patchset #1 id:1 of https://codereview.chromium.org/1047013002/) Reason for revert: Not a culprit. Bring it back. Original issue's description: > Revert of Fix text clipping in CompositorFrameTime Display (patchset #2 id:20001 of https://codereview.chromium.org/1027393004/) > > Reason for revert: > Speculative revert for Blink layout test failures in WebKit Mac10.8 (retina): > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/27696 > > Original issue's description: > > Fix text clipping in CompositorFrameTime Display > > > > Because different OS have different fonts for HUD. > > Set the width of CompositorFrameTime Display to be maximum > > of graph width and text width to prevent text clipping. > > > > BUG=445877 > > > > Committed: https://crrev.com/88b4cf8d33b499f972e1c447e741230170beeb8d > > Cr-Commit-Position: refs/heads/master@{#322807} > > TBR=danakj@chromium.org,behara.ms@samsung.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=445877 > > Committed: https://crrev.com/933b39f06e409d623eb4dbc4da692ae41460372e > Cr-Commit-Position: refs/heads/master@{#322858} TBR=danakj@chromium.org,behara.ms@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445877 Committed: https://crrev.com/05ec069bfb1e10e8f344937793a21b3715549170 Cr-Commit-Position: refs/heads/master@{#322908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 3 chunks +28 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
Created Revert of Revert of Fix text clipping in CompositorFrameTime Display
5 years, 8 months ago (2015-03-30 23:37:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043023002/1
5 years, 8 months ago (2015-03-30 23:39:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 23:40:44 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 23:41:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05ec069bfb1e10e8f344937793a21b3715549170
Cr-Commit-Position: refs/heads/master@{#322908}

Powered by Google App Engine
This is Rietveld 408576698