Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: components/storage_monitor/storage_monitor_mac.mm

Issue 1043013002: favor DCHECK_CURRENTLY_ON for better logs in components/ (part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master + add one more Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/storage_monitor/storage_monitor_mac.mm
diff --git a/components/storage_monitor/storage_monitor_mac.mm b/components/storage_monitor/storage_monitor_mac.mm
index d8055dce9fa01ae0d477f659874fadb079ea2ec2..c9b14e2247e0ccd2a360df6700dbd72e3fc35659 100644
--- a/components/storage_monitor/storage_monitor_mac.mm
+++ b/components/storage_monitor/storage_monitor_mac.mm
@@ -47,7 +47,7 @@ StorageInfo::Type GetDeviceType(bool is_removable, bool has_dcim) {
StorageInfo BuildStorageInfo(
CFDictionaryRef dict, std::string* bsd_name) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
CFStringRef device_bsd_name = base::mac::GetValueFromDictionary<CFStringRef>(
dict, kDADiskDescriptionMediaBSDNameKey);
@@ -109,7 +109,7 @@ void GetDiskInfoAndUpdateOnFileThread(
const base::WeakPtr<StorageMonitorMac>& monitor,
base::ScopedCFTypeRef<CFDictionaryRef> dict,
StorageMonitorMac::UpdateType update_type) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
std::string bsd_name;
StorageInfo info = BuildStorageInfo(dict, &bsd_name);
@@ -209,7 +209,7 @@ void StorageMonitorMac::UpdateDisk(
const std::string& bsd_name,
const StorageInfo& info,
UpdateType update_type) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
pending_disk_updates_--;
bool initialization_complete = false;
@@ -348,7 +348,7 @@ void StorageMonitorMac::DiskDescriptionChangedCallback(DADiskRef disk,
void StorageMonitorMac::GetDiskInfoAndUpdate(
DADiskRef disk,
StorageMonitorMac::UpdateType update_type) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
pending_disk_updates_++;

Powered by Google App Engine
This is Rietveld 408576698