Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1043003002: keep mixin and interface implementation info at runtime (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -10 lines) Patch
M lib/runtime/dart/_interceptors.js View 9 chunks +9 lines, -0 lines 0 comments Download
M lib/runtime/dart/_internal.js View 12 chunks +13 lines, -0 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 8 chunks +8 lines, -0 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 17 chunks +17 lines, -0 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 20 chunks +20 lines, -0 lines 0 comments Download
M lib/runtime/dart/async.js View 30 chunks +30 lines, -0 lines 0 comments Download
M lib/runtime/dart/collection.js View 35 chunks +35 lines, -0 lines 0 comments Download
M lib/runtime/dart/convert.js View 9 chunks +9 lines, -0 lines 0 comments Download
M lib/runtime/dart/core.js View 18 chunks +19 lines, -0 lines 0 comments Download
M lib/runtime/dart/isolate.js View 6 chunks +6 lines, -0 lines 0 comments Download
M lib/runtime/dart/math.js View 3 chunks +3 lines, -0 lines 0 comments Download
M lib/runtime/dart/typed_data.js View 15 chunks +15 lines, -0 lines 0 comments Download
M lib/runtime/dart_runtime.js View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 4 chunks +17 lines, -6 lines 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
as we were discussing :)
5 years, 8 months ago (2015-03-30 22:28:41 UTC) #2
Jacob
lgtm
5 years, 8 months ago (2015-03-30 22:52:00 UTC) #3
Jennifer Messerly
I just realized we also need to emit the placeholder for interfaces without codegen
5 years, 8 months ago (2015-03-30 22:56:11 UTC) #4
vsm
lgtm
5 years, 8 months ago (2015-03-30 22:56:18 UTC) #5
Jennifer Messerly
5 years, 8 months ago (2015-03-30 23:09:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dabf139da6fecf9a1d7c05bbfc8fccc148c93f4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698