Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: lib/runtime/dart/_js_helper.js

Issue 1042943003: fixes private named constructors (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_isolate_helper.js ('k') | lib/runtime/dart/_native_typed_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_js_helper.js
diff --git a/lib/runtime/dart/_js_helper.js b/lib/runtime/dart/_js_helper.js
index faa7ee83d784f202b7696a126db4887d93149e63..7c2ae2eafe4c6a22e74319b02a6cac933215d335 100644
--- a/lib/runtime/dart/_js_helper.js
+++ b/lib/runtime/dart/_js_helper.js
@@ -23,11 +23,11 @@ var _js_helper;
this.name = name;
}
}
- let _throwUnmodifiable = Symbol('_throwUnmodifiable');
let _$ = Symbol('_');
+ let _throwUnmodifiable = Symbol('_throwUnmodifiable');
let ConstantMap$ = dart.generic(function(K, V) {
class ConstantMap extends core.Object {
- ConstantMap$_() {
+ [_$]() {
}
get isEmpty() {
return this.length === 0;
@@ -66,11 +66,11 @@ var _js_helper;
let _fetch = Symbol('_fetch');
let ConstantStringMap$ = dart.generic(function(K, V) {
class ConstantStringMap extends ConstantMap$(K, V) {
- ConstantStringMap$_(length, jsObject$, keys$) {
+ [_$](length, jsObject$, keys$) {
this.length = length;
this[_jsObject] = jsObject$;
this[_keys] = keys$;
- super.ConstantMap$_();
+ super[_$]();
}
containsValue(needle) {
return this.values.any((value) => dart.equals(value, needle));
@@ -111,9 +111,9 @@ var _js_helper;
let _protoValue = Symbol('_protoValue');
let ConstantProtoMap$ = dart.generic(function(K, V) {
class ConstantProtoMap extends ConstantStringMap$(K, V) {
- ConstantProtoMap$_(length, jsObject, keys, protoValue) {
+ [_$](length, jsObject, keys, protoValue) {
this[_protoValue] = protoValue;
- super.ConstantStringMap$_(dart.as(length, core.int), jsObject, dart.as(keys, core.List$(K)));
+ super[_$](dart.as(length, core.int), jsObject, dart.as(keys, core.List$(K)));
}
containsKey(key) {
if (!(typeof key == 'string'))
@@ -153,7 +153,7 @@ var _js_helper;
class GeneralConstantMap extends ConstantMap$(K, V) {
GeneralConstantMap(jsData) {
this[_jsData] = jsData;
- super.ConstantMap$_();
+ super[_$]();
}
[_getMap]() {
if (!this.$map) {
@@ -1598,7 +1598,7 @@ var _js_helper;
}
}
class ReflectionInfo extends core.Object {
- ReflectionInfo$internal(jsFunction, data, isAccessor, requiredParameterCount, optionalParameterCount, areOptionalParametersNamed, functionType) {
+ internal(jsFunction, data, isAccessor, requiredParameterCount, optionalParameterCount, areOptionalParametersNamed, functionType) {
this.jsFunction = jsFunction;
this.data = data;
this.isAccessor = isAccessor;
@@ -3180,7 +3180,7 @@ var _js_helper;
this.message = `type '${Primitives.objectTypeName(value)}' is not a subtype ` + `of type '${type}'`;
super.Error();
}
- TypeErrorImplementation$fromMessage(message) {
+ fromMessage(message) {
this.message = message;
super.Error();
}
« no previous file with comments | « lib/runtime/dart/_isolate_helper.js ('k') | lib/runtime/dart/_native_typed_data.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698