Issue 1042943003: fixes private named constructors

Issue 1042943003: fixes private named constructors (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+349 lines, -353 lines)			Patch
M	lib/runtime/dart/_interceptors.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	lib/runtime/dart/_internal.js	View	8 chunks	+13 lines, -13 lines	0 comments	Download
M	lib/runtime/dart/_isolate_helper.js	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	lib/runtime/dart/_js_helper.js	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/runtime/dart/_native_typed_data.js	View	41 chunks	+118 lines, -118 lines	0 comments	Download
M	lib/runtime/dart/async.js	View	15 chunks	+22 lines, -22 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View	14 chunks	+25 lines, -25 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View	10 chunks	+18 lines, -20 lines	0 comments	Download
M	lib/runtime/dart/core.js	View	29 chunks	+54 lines, -54 lines	0 comments	Download
M	lib/runtime/dart/isolate.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/runtime/dart/math.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/runtime/dart/typed_data.js	View	19 chunks	+42 lines, -42 lines	0 comments	Download
M	lib/runtime/dart_runtime.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	test/codegen/expect/constructors.js	View	4 chunks	+13 lines, -13 lines	0 comments	Download
M	test/codegen/expect/names.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/codegen/expect/server_mode/html_input.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

(we've bounced back a bit between the naming scheme for init methods, Type$ctor vs ctor ...

5 years, 8 months ago (2015-03-30 20:54:46 UTC) #2

Jennifer Messerly

5 years, 8 months ago (2015-03-30 21:30:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e23538a814897e5de6c127a4a4125cc19a33e16e (presubmit successful).