Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1042903004: [Ozone-Drm] Fallback silently when main thread runner is not present (Closed)

Created:
5 years, 8 months ago by vignatti (out of this project)
Modified:
5 years, 8 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Drm] Fallback silently when main thread runner is not present BUG=471261 TEST=GBM platform on gpu_unittests and content_unittests

Patch Set 1 #

Patch Set 2 : fix conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vignatti (out of this project)
PTAL.
5 years, 8 months ago (2015-03-30 20:47:49 UTC) #2
vignatti (out of this project)
spang@ PTAL here. I'm starting to think that the most practical way to fix the ...
5 years, 8 months ago (2015-04-06 23:55:53 UTC) #3
spang
On 2015/04/06 23:55:53, vignatti wrote: > spang@ PTAL here. > > I'm starting to think ...
5 years, 8 months ago (2015-04-07 19:04:31 UTC) #4
vignatti (out of this project)
5 years, 8 months ago (2015-04-08 21:59:33 UTC) #5
On 2015/04/07 19:04:31, spang wrote:
> On 2015/04/06 23:55:53, vignatti wrote:
> > spang@ PTAL here. 
> > 
> > I'm starting to think that the most practical way to fix the unit tests (and
> > avoid CL 1043233003 entirely) is doing like this... after all, the main
thread
> > runner, which is the source of all the trouble, is a temporary solution for
> the
> > cursor stuff and hopefully that won't be needed eventually.
> 
> Is it worth having a hack for this?
> 
> We don't run these unit tests with gbm on the waterfall (and realistically,
> probably cannot do so). I'm not sure if it is actually even worthwhile to try,
> because they are unit tests for other components and should not depend on
> particular behavior at the platform layer.
> 
> If you could elaborate as to why you need it to work, that would help justify
> why we need to check in a hack to support it.

noupe, we agreed that it's not worth this:
https://code.google.com/p/chromium/issues/detail?id=471261#c3

closing this CL as well.

Powered by Google App Engine
This is Rietveld 408576698