Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1633)

Unified Diff: Source/devtools/front_end/elements/EventListenersSidebarPane.js

Issue 1042853004: [DevTools] Event Listeners Sidebar shows window listeners (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/EventListenersSidebarPane.js
diff --git a/Source/devtools/front_end/elements/EventListenersSidebarPane.js b/Source/devtools/front_end/elements/EventListenersSidebarPane.js
index 9fa00c3bab4ce9761abe9e7f02357f8d85b6802b..15b3cee72d5ebff633760a4049819231a89cff8b 100644
--- a/Source/devtools/front_end/elements/EventListenersSidebarPane.js
+++ b/Source/devtools/front_end/elements/EventListenersSidebarPane.js
@@ -229,7 +229,10 @@ WebInspector.EventListenerBar.prototype = {
WebInspector.ObjectPropertyTreeElement.populateWithProperties(this, properties, [], true, null);
}
- this._eventListener.node().resolveToObject(WebInspector.EventListenersSidebarPane._objectGroupName, updateWithNodeObject.bind(this));
+ if (this._eventListener.node())
+ this._eventListener.node().resolveToObject(WebInspector.EventListenersSidebarPane._objectGroupName, updateWithNodeObject.bind(this));
+ else
+ updateWithNodeObject.call(this, null);
},
/**
@@ -238,14 +241,17 @@ WebInspector.EventListenerBar.prototype = {
_setNodeTitle: function(linkifier)
{
var node = this._eventListener.node();
- if (!node)
- return;
this.listItemElement.removeChildren();
var title = this.listItemElement.createChild("span");
var subtitle = this.listItemElement.createChild("span", "event-listener-tree-subtitle");
subtitle.appendChild(linkifier.linkifyRawLocation(this._eventListener.location(), this._eventListener.sourceName()));
+ if (!node) {
+ title.textContent = "window";
+ return;
+ }
+
if (node.nodeType() === Node.DOCUMENT_NODE) {
title.textContent = "document";
return;

Powered by Google App Engine
This is Rietveld 408576698