Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1042843002: [Crankshaft] Don't add an instruction twice for %_StringGetLength. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Crankshaft] Don't add an instruction twice for %_StringGetLength. Committed: https://crrev.com/55a64bf78173d5b5f0fe8cee3538fa6056080737 Cr-Commit-Position: refs/heads/master@{#27521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 8 months ago (2015-03-30 11:45:27 UTC) #2
Michael Starzinger
LGTM.
5 years, 8 months ago (2015-03-30 12:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042843002/1
5 years, 8 months ago (2015-03-30 12:40:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 12:42:00 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 12:42:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a64bf78173d5b5f0fe8cee3538fa6056080737
Cr-Commit-Position: refs/heads/master@{#27521}

Powered by Google App Engine
This is Rietveld 408576698