Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1042813003: Refactor of password manager client unittests. (Closed)

Created:
5 years, 8 months ago by melandory
Modified:
5 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor of password manager client unittests. BUG=450583 R=vabr@chromium.org Committed: https://crrev.com/0c443278dd1e042381ccf65922c2872bd6dd6e26 Cr-Commit-Position: refs/heads/master@{#322795}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 5 chunks +22 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
melandory
Hi Vaclav, review this CL, please. Thanks in advance.
5 years, 8 months ago (2015-03-30 16:17:24 UTC) #1
vabr (Chromium)
LGTM, Thanks for the improvements! Vaclav
5 years, 8 months ago (2015-03-30 16:28:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042813003/20001
5 years, 8 months ago (2015-03-30 16:29:25 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-30 17:04:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 17:05:05 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c443278dd1e042381ccf65922c2872bd6dd6e26
Cr-Commit-Position: refs/heads/master@{#322795}

Powered by Google App Engine
This is Rietveld 408576698