Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1042803002: Drive: Move inner structures of DriveAPIService under drive namespace. (Closed)

Created:
5 years, 8 months ago by hirono
Modified:
5 years, 8 months ago
Reviewers:
mtomasz, tzik
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, tzik, tfarina, maxbogue+watch_chromium.org, nhiroki, pvalenzuela+watch_chromium.org, rginda+watch_chromium.org, plaree+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drive: Move inner structures of DriveAPIService under drive namespace. The structures will be shared with BatchRequestBuilder introduced by the following CLs. BUG=451917 TEST=None Committed: https://crrev.com/516b766cd373bf4ad94a75f04559ad9b35746c6c Cr-Commit-Position: refs/heads/master@{#322958}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -342 lines) Patch
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 2 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 9 chunks +24 lines, -54 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 2 chunks +67 lines, -67 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/drive/drive_uploader.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/drive/drive_uploader_unittest.cc View 10 chunks +23 lines, -35 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 1 19 chunks +22 lines, -33 lines 0 comments Download
M chrome/browser/drive/test_util.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_wrapper.h View 1 chunk +12 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_wrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hirono
@tzik - PTAL chrome/browser/sync_file_system/* @mtomasz - PTAL others Thank you!
5 years, 8 months ago (2015-03-30 08:21:51 UTC) #2
mtomasz
In general lgtm. There seem to be compile errors.
5 years, 8 months ago (2015-03-30 08:27:36 UTC) #3
tzik
lgtm
5 years, 8 months ago (2015-03-31 02:15:33 UTC) #4
hirono
On 2015/03/31 02:15:33, tzik wrote: > lgtm Thank you!
5 years, 8 months ago (2015-03-31 02:19:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042803002/2
5 years, 8 months ago (2015-03-31 02:19:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 8 months ago (2015-03-31 02:23:54 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 02:24:47 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/516b766cd373bf4ad94a75f04559ad9b35746c6c
Cr-Commit-Position: refs/heads/master@{#322958}

Powered by Google App Engine
This is Rietveld 408576698