Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: extensions/common/permissions/api_permission_set.h

Issue 1042793003: Extensions: Switch to new permission message system, part II (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_switch
Patch Set: review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/api_permission_set.h
diff --git a/extensions/common/permissions/api_permission_set.h b/extensions/common/permissions/api_permission_set.h
index fb8bde9b386eb6c12ff2ed3d667fbcf96fbf36b6..5b21db1d9a001093eb40e72b948fc2a622d14133 100644
--- a/extensions/common/permissions/api_permission_set.h
+++ b/extensions/common/permissions/api_permission_set.h
@@ -111,6 +111,8 @@ class PermissionID : public std::pair<APIPermission::ID, base::string16> {
// instead of pointers and change this to extend BaseSetOperators<PermissionID>.
class PermissionIDSet {
public:
+ using const_iterator = std::set<PermissionID>::const_iterator;
+
PermissionIDSet();
virtual ~PermissionIDSet();
@@ -132,6 +134,7 @@ class PermissionIDSet {
// Convenience functions that call their stl_util counterparts.
bool Includes(const PermissionIDSet& subset) const;
+ bool Equals(const PermissionIDSet& set) const;
static PermissionIDSet Difference(const PermissionIDSet& set_1,
const PermissionIDSet& set_2);
static PermissionIDSet Intersection(const PermissionIDSet& set_1,
@@ -142,6 +145,9 @@ class PermissionIDSet {
size_t size() const;
bool empty() const;
+ const_iterator begin() const { return permissions_.begin(); }
+ const_iterator end() const { return permissions_.end(); }
+
private:
PermissionIDSet(std::set<PermissionID> permissions);
Devlin 2015/04/07 15:55:56 Not your doing, but can you make this const std::s
Marc Treib 2015/04/07 16:15:55 Done. (Good catch!)
« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | extensions/common/permissions/api_permission_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698