Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5312)

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 1042793003: Extensions: Switch to new permission message system, part II (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_switch
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/chrome_permission_message_rules.cc
diff --git a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
index d95ea1fdad386dfd6610efab426e1383e2f2d953..dbe5fe1fd03789f460add42fc959e7d4a9a59835 100644
--- a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
+++ b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
@@ -345,9 +345,9 @@ ChromePermissionMessageRule::GetAllRules() {
{IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS,
{APIPermission::kSessions, APIPermission::kHistory},
- {APIPermission::kTab,
- APIPermission::kFavicon,
+ {APIPermission::kFavicon,
APIPermission::kProcesses,
+ APIPermission::kTab,
APIPermission::kTopSites,
APIPermission::kWebNavigation}},
{IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS,
@@ -372,8 +372,10 @@ ChromePermissionMessageRule::GetAllRules() {
{IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE,
{APIPermission::kHistory},
{APIPermission::kFavicon,
+ APIPermission::kProcesses,
APIPermission::kTab,
- APIPermission::kTopSites}},
+ APIPermission::kTopSites,
+ APIPermission::kWebNavigation}},
// A special hack: If kFileSystemWriteDirectory would be displayed, hide
// kFileSystemDirectory as the write directory message implies it.
// TODO(sashab): Remove kFileSystemWriteDirectory; it's no longer needed
@@ -404,7 +406,10 @@ ChromePermissionMessageRule::GetAllRules() {
// frequently visited sites.
{IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,
{APIPermission::kTab},
- {APIPermission::kFavicon, APIPermission::kTopSites}},
+ {APIPermission::kFavicon,
+ APIPermission::kProcesses,
+ APIPermission::kTopSites,
+ APIPermission::kWebNavigation}},
// Individual message rules taken from
// ChromeAPIPermissions::GetAllPermissions():

Powered by Google App Engine
This is Rietveld 408576698