Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 1042793003: Extensions: Switch to new permission message system, part II (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_switch
Patch Set: nit Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/permissions/chrome_permission_message_rules.h " 5 #include "chrome/common/extensions/permissions/chrome_permission_message_rules.h "
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "extensions/common/permissions/api_permission_set.h" 10 #include "extensions/common/permissions/api_permission_set.h"
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 {IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ_DELETE, 338 {IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ_DELETE,
339 {APIPermission::kMediaGalleriesAllGalleriesDelete, 339 {APIPermission::kMediaGalleriesAllGalleriesDelete,
340 APIPermission::kMediaGalleriesAllGalleriesRead}, 340 APIPermission::kMediaGalleriesAllGalleriesRead},
341 {}}, 341 {}},
342 {IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ, 342 {IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ,
343 {APIPermission::kMediaGalleriesAllGalleriesRead}, 343 {APIPermission::kMediaGalleriesAllGalleriesRead},
344 {}}, 344 {}},
345 345
346 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS, 346 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS,
347 {APIPermission::kSessions, APIPermission::kHistory}, 347 {APIPermission::kSessions, APIPermission::kHistory},
348 {APIPermission::kTab, 348 {APIPermission::kFavicon,
349 APIPermission::kFavicon,
350 APIPermission::kProcesses, 349 APIPermission::kProcesses,
350 APIPermission::kTab,
351 APIPermission::kTopSites, 351 APIPermission::kTopSites,
352 APIPermission::kWebNavigation}}, 352 APIPermission::kWebNavigation}},
353 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS, 353 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS,
354 {APIPermission::kSessions, APIPermission::kTab}, 354 {APIPermission::kSessions, APIPermission::kTab},
355 {APIPermission::kFavicon, 355 {APIPermission::kFavicon,
356 APIPermission::kProcesses, 356 APIPermission::kProcesses,
357 APIPermission::kTopSites, 357 APIPermission::kTopSites,
358 APIPermission::kWebNavigation}}, 358 APIPermission::kWebNavigation}},
359 359
360 // Suppression list taken from 360 // Suppression list taken from
361 // ChromePermissionMessageProvider::GetPermissionMessages(): 361 // ChromePermissionMessageProvider::GetPermissionMessages():
362 // Some warnings are more generic and/or powerful and supercede other 362 // Some warnings are more generic and/or powerful and supercede other
363 // warnings. In that case, the first message suppresses the second one. 363 // warnings. In that case, the first message suppresses the second one.
364 {IDS_EXTENSION_PROMPT_WARNING_BLUETOOTH, 364 {IDS_EXTENSION_PROMPT_WARNING_BLUETOOTH,
365 {APIPermission::kBluetooth}, 365 {APIPermission::kBluetooth},
366 {APIPermission::kBluetoothDevices}}, 366 {APIPermission::kBluetoothDevices}},
367 {IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS, 367 {IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,
368 {APIPermission::kBookmark}, 368 {APIPermission::kBookmark},
369 {APIPermission::kOverrideBookmarksUI}}, 369 {APIPermission::kOverrideBookmarksUI}},
370 // History already allows reading favicons, tab access and accessing the 370 // History already allows reading favicons, tab access and accessing the
371 // list of most frequently visited sites. 371 // list of most frequently visited sites.
372 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE, 372 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE,
373 {APIPermission::kHistory}, 373 {APIPermission::kHistory},
374 {APIPermission::kFavicon, 374 {APIPermission::kFavicon,
375 APIPermission::kProcesses,
375 APIPermission::kTab, 376 APIPermission::kTab,
376 APIPermission::kTopSites}}, 377 APIPermission::kTopSites,
378 APIPermission::kWebNavigation}},
377 // A special hack: If kFileSystemWriteDirectory would be displayed, hide 379 // A special hack: If kFileSystemWriteDirectory would be displayed, hide
378 // kFileSystemDirectory as the write directory message implies it. 380 // kFileSystemDirectory as the write directory message implies it.
379 // TODO(sashab): Remove kFileSystemWriteDirectory; it's no longer needed 381 // TODO(sashab): Remove kFileSystemWriteDirectory; it's no longer needed
380 // since this rules system can represent the rule. See crbug.com/284849. 382 // since this rules system can represent the rule. See crbug.com/284849.
381 {IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE_DIRECTORY, 383 {IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE_DIRECTORY,
382 {APIPermission::kFileSystemWrite, APIPermission::kFileSystemDirectory}, 384 {APIPermission::kFileSystemWrite, APIPermission::kFileSystemDirectory},
383 {APIPermission::kFileSystemWriteDirectory}}, 385 {APIPermission::kFileSystemWriteDirectory}},
384 // Full access already allows DeclarativeWebRequest, reading the list of 386 // Full access already allows DeclarativeWebRequest, reading the list of
385 // most frequently visited sites, and tab access. 387 // most frequently visited sites, and tab access.
386 // The warning message for declarativeWebRequest 388 // The warning message for declarativeWebRequest
(...skipping 10 matching lines...) Expand all
397 APIPermission::kTopSites, 399 APIPermission::kTopSites,
398 APIPermission::kHostsAllReadOnly}}, 400 APIPermission::kHostsAllReadOnly}},
399 // AutomationManifestPermission: 401 // AutomationManifestPermission:
400 {IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS_READ_ONLY, 402 {IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS_READ_ONLY,
401 {APIPermission::kHostsAllReadOnly}, 403 {APIPermission::kHostsAllReadOnly},
402 {}}, 404 {}},
403 // Tabs already allows reading favicons and reading the list of most 405 // Tabs already allows reading favicons and reading the list of most
404 // frequently visited sites. 406 // frequently visited sites.
405 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ, 407 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,
406 {APIPermission::kTab}, 408 {APIPermission::kTab},
407 {APIPermission::kFavicon, APIPermission::kTopSites}}, 409 {APIPermission::kFavicon,
410 APIPermission::kProcesses,
411 APIPermission::kTopSites,
412 APIPermission::kWebNavigation}},
408 413
409 // Individual message rules taken from 414 // Individual message rules taken from
410 // ChromeAPIPermissions::GetAllPermissions(): 415 // ChromeAPIPermissions::GetAllPermissions():
411 // Permission messages for all extension types: 416 // Permission messages for all extension types:
412 417
413 {IDS_EXTENSION_PROMPT_WARNING_CLIPBOARD, 418 {IDS_EXTENSION_PROMPT_WARNING_CLIPBOARD,
414 {APIPermission::kClipboardRead}, 419 {APIPermission::kClipboardRead},
415 {}}, 420 {}},
416 {IDS_EXTENSION_PROMPT_WARNING_DESKTOP_CAPTURE, 421 {IDS_EXTENSION_PROMPT_WARNING_DESKTOP_CAPTURE,
417 {APIPermission::kDesktopCapture}, 422 {APIPermission::kDesktopCapture},
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 insert(permission_four); 666 insert(permission_four);
662 insert(permission_five); 667 insert(permission_five);
663 insert(permission_six); 668 insert(permission_six);
664 } 669 }
665 670
666 ChromePermissionMessageRule::PermissionIDSetInitializer:: 671 ChromePermissionMessageRule::PermissionIDSetInitializer::
667 ~PermissionIDSetInitializer() { 672 ~PermissionIDSetInitializer() {
668 } 673 }
669 674
670 } // namespace extensions 675 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698