extensions/browser/guest_view/guest_view_manager.h - Issue 1042743002: Make Edit>Speech>Speak Selection work for PDFs on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager.h

Issue 1042743002: Make Edit>Speech>Speak Selection work for PDFs on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/browser_plugin_guest_manager.h ('K') | « content/public/browser/browser_plugin_guest_manager.cc ('k') | extensions/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_manager.h

diff --git a/extensions/browser/guest_view/guest_view_manager.h b/extensions/browser/guest_view/guest_view_manager.h

index 934c46747dd4656b813caf6118ed1df0fbfac3d9..171ee348ac3dafa1131448f1479d0edaf7f7b427 100644

--- a/extensions/browser/guest_view/guest_view_manager.h

+++ b/extensions/browser/guest_view/guest_view_manager.h

@@ -92,6 +92,8 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

int element_instance_id) override;

bool ForEachGuest(content::WebContents* owner_web_contents,

const GuestCallback& callback) override;

+ content::WebContents* GetFullPageGuest(

+ content::WebContents* embedder_web_contents) override;

protected:

friend class GuestViewBase;

@@ -119,6 +121,9 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

// from this manager using RemoveGuest.

bool CanUseGuestInstanceID(int guest_instance_id);

+ static bool GetFullPageGuestHelper(content::WebContents** result,

+ content::WebContents* guest_web_contents);

// Static factory instance (always NULL for non-test).

static GuestViewManagerFactory* factory_;