Chromium Code Reviews
DescriptionListPicker calculate accurate scroll height
The vertical scrollbar was being displayed when it shouldn't be because the scroll dimensions would be fractional values and we hasVerticalScrollbar was returning false negatives. Element.scrollHeight returns the floored value so this CL calculates the fractional scroll height using getBoundingClientRect which returns fractional values.
BUG=470505
TEST=Added popup-menu-appearance-fractional-width.html
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192924
Patch Set 1 #Patch Set 2 : Added test #Patch Set 3 : Fixed test name #Patch Set 4 : Rebaselining pixel tests with shorter popup height #Patch Set 5 : Fixe problem with scrollHeight calculation when hidden options and no options #
Messages
Total messages: 14 (7 generated)
|
|||||||||||||||||||||||||||||||||||||