Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1042733002: ListPicker calculate accurate scroll height (Closed)

Created:
5 years, 8 months ago by keishi
Modified:
5 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

ListPicker calculate accurate scroll height The vertical scrollbar was being displayed when it shouldn't be because the scroll dimensions would be fractional values and we hasVerticalScrollbar was returning false negatives. Element.scrollHeight returns the floored value so this CL calculates the fractional scroll height using getBoundingClientRect which returns fractional values. BUG=470505 TEST=Added popup-menu-appearance-fractional-width.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192924

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Fixed test name #

Patch Set 4 : Rebaselining pixel tests with shorter popup height #

Patch Set 5 : Fixe problem with scrollHeight calculation when hidden options and no options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/select/popup-menu-appearance-fractional-width.html View 1 2 1 chunk +15 lines, -6 lines 0 comments Download
M Source/web/resources/listPicker.js View 1 2 3 4 2 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
keishi
5 years, 8 months ago (2015-03-31 04:38:14 UTC) #2
tkent
lgtm
5 years, 8 months ago (2015-03-31 04:49:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042733002/20001
5 years, 8 months ago (2015-03-31 04:51:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042733002/40001
5 years, 8 months ago (2015-03-31 04:57:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/54988)
5 years, 8 months ago (2015-03-31 08:23:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042733002/80001
5 years, 8 months ago (2015-04-01 05:25:57 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 11:29:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192924

Powered by Google App Engine
This is Rietveld 408576698