Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1042683003: Do nothing when sweeping is in progress. (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do nothing when sweeping is in progress. We still try to do incremental steps before this patch (as incremental marking is in state "Sweeping" and not "stopped") BUG=none R=hpayer@chromium.org LOG=n

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/heap/gc-idle-time-handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-03-30 12:26:51 UTC) #1
Hannes Payer (out of office)
5 years, 8 months ago (2015-03-30 14:39:04 UTC) #2
OK, make sense. I think right now an incremental marking step would finish
sweeping.

Could you please add a test case?

Powered by Google App Engine
This is Rietveld 408576698