Issue 1042683003: Do nothing when sweeping is in progress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1042683003: Do nothing when sweeping is in progress. (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 8 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Do nothing when sweeping is in progress. We still try to do incremental steps before this patch (as incremental marking is in state "Sweeping" and not "stopped") BUG=none R=hpayer@chromium.org LOG=n

Patch Set 1 #

Patch Set 2 : updates #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	src/heap/gc-idle-time-handler.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	test/unittests/heap/gc-idle-time-handler-unittest.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

5 years, 8 months ago (2015-03-30 14:39:04 UTC) #2

OK, make sense. I think right now an incremental marking step would finish
sweeping.

Could you please add a test case?

Expand Messages | Collapse Messages