Issue 1042643002: PNaCl: Strip `nonnull` attributes from pointer arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1042643002: PNaCl: Strip `nonnull` attributes from pointer arguments. (Closed)

Created:
5 years, 9 months ago by Richard Diamond

Modified:
5 years, 8 months ago

Reviewers:
JF

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

PNaCl: Strip `nonnull` attributes from pointer arguments. R=jfb@chromium.org TEST= (make -C toolchain_build/out/llvm_x86_64_linux_work -j `nproc` check) BUG= Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=bf706a52911ea12b388504e5d7095118ad338376

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	lib/Transforms/NaCl/ReplacePtrsWithInts.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/Transforms/NaCl/replace-ptrs-with-ints.ll	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Committed patchset #1 (id:1) manually as bf706a52911ea12b388504e5d7095118ad338376 (presubmit successful).

5 years, 8 months ago (2015-03-29 17:17:26 UTC) #3

Richard Diamond

5 years, 8 months ago (2015-03-30 00:19:03 UTC) #4

Message was sent while issue was closed.

On 2015/03/29 at 17:16:12, jfb wrote:
> Good catch, I also added dereferenceable. lgtm.

Interesting that it hasn't been a problem yet: Rust puts dereferenceable
attributes everywhere. Nevertheless, good catch yourself!

Expand Messages | Collapse Messages