Issue 1042633003: Reverts recent changes to StatusBubbleMac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1042633003: Reverts recent changes to StatusBubbleMac. (Closed)

Created:
5 years, 8 months ago by rohitrao (ping after 24h)

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reverts recent changes to StatusBubbleMac. Recent cleanup and performance changes caused a regression in the fullscreen transition animation, leading to this revert. This reverts commit 9ec18e41d4a50ebb61849921602a4dae996f448d. This reverts commit b62daf588fe52c461c8b2c09771dbb32fbfdbab6. This reverts commit 014fd0a1313597e72bc99a46795cb778a8e40149. TBR=erikchen@chromium.org BUG=470180, 464754, 454502 TEST=None Committed: https://crrev.com/7a15c8173fca5413fe61113b82185fe721ce0b98 Cr-Commit-Position: refs/heads/master@{#322728}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -96 lines)			Patch
	M	chrome/browser/ui/cocoa/status_bubble_mac.mm	View		8 chunks	+12 lines, -80 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm	View		1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042633003/1

5 years, 8 months ago (2015-03-29 21:17:32 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-03-29 21:20:34 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7a15c8173fca5413fe61113b82185fe721ce0b98
Cr-Commit-Position: refs/heads/master@{#322728}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages